ios/web/web_state/ui/crw_web_controller.mm - Issue 2810263002: Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2810263002: Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it. (Closed)

Patch Set: Moved didFinishNavigation to legacy.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 4d87b2c3da8df85af85d482cbd6a74a833044682..7548d116d32576a82a5da770fd1bb4f750dc7b8b 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -2682,11 +2682,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

- (BOOL)handleWindowHashChangeMessage:(base::DictionaryValue*)message

context:(NSDictionary*)context {

- // Because hash changes don't trigger |-didFinishNavigation|, fetch favicons

- // for the new page manually.

- [self executeJavaScript:@"__gCrWeb.sendFaviconsToHost();"

- completionHandler:nil];

// Record that the current NavigationItem was created by a hash change, but

// ignore hashchange events that are manually dispatched for same-document

// navigations.

« no previous file with comments | « ios/web/web_state/js/resources/web_bundle.js ('k') | no next file » | no next file with comments »