[Payments] Change how the dialog gets destroyed.

[Payments] Change how the dialog gets destroyed.

The views need to go first, then the controllers. This is because some
views may have pointers/delegates back to their controllers.

BUG=710127
TEST=a few more browser_tests

Review-Url: https://codereview.chromium.org/2810193003
Cr-Commit-Position: refs/heads/master@{#464026}
Committed: https://chromium.googlesource.com/chromium/src/+/457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49

[Mathieu, 2017-04-12 13:29:01]

mathp@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Mathieu, 2017-04-12 13:29:02]

Anthony, PTAL!

https://codereview.chromium.org/2810193003/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.h (right):

https://codereview.chromium.org/2810193003/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.h:65:
std::vector<std::unique_ptr<views::View>> stack_;
The order is important here, because views need to be destroyed before the
view-stack-wide animators and members get destroyed in reverse order. Otherwise
you'd destroy the two animators before all the views, which is wrong.

[Mathieu, 2017-04-12 13:29:14]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 13:29:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 14:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 14:11:41]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2017-04-12 14:19:36]

lgtm % 1 comment. Does this fix your editor issue?

https://codereview.chromium.org/2810193003/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.h (right):

https://codereview.chromium.org/2810193003/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.h:65:
std::vector<std::unique_ptr<views::View>> stack_;
On 2017/04/12 at 13:29:02, Mathieu wrote:
> The order is important here, because views need to be destroyed before the
view-stack-wide animators and members get destroyed in reverse order. Otherwise
you'd destroy the two animators before all the views, which is wrong.

Good catch, can you please add a comment about this?

[Mathieu, 2017-04-12 14:24:23]

https://codereview.chromium.org/2810193003/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.h (right):

https://codereview.chromium.org/2810193003/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.h:65:
std::vector<std::unique_ptr<views::View>> stack_;
On 2017/04/12 14:19:36, anthonyvd wrote:
> On 2017/04/12 at 13:29:02, Mathieu wrote:
> > The order is important here, because views need to be destroyed before the
> view-stack-wide animators and members get destroyed in reverse order.
Otherwise
> you'd destroy the two animators before all the views, which is wrong.
> 
> Good catch, can you please add a comment about this?

Done.

[Mathieu, 2017-04-12 14:24:27]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-12 14:24:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2810193003/#ps20001
(title: "added comment")

[commit-bot: I haz the power, 2017-04-12 14:24:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:14:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492007067045280,
"parent_rev": "78a049660074003b8e1e602b0e7783ca7f1f4ee0", "commit_rev":
"457dcdd09c5fe44b8eb75bcdb0b7b8beab158b49"}

[commit-bot: I haz the power, 2017-04-12 15:15:53]

Description was changed from

==========
[Payments] Change how the dialog gets destroyed.

The views need to go first, then the controllers. This is because some
views may have pointers/delegates back to their controllers.

BUG=710127
TEST=a few more browser_tests
==========

to

==========
[Payments] Change how the dialog gets destroyed.

The views need to go first, then the controllers. This is because some
views may have pointers/delegates back to their controllers.

BUG=710127
TEST=a few more browser_tests

Review-Url: https://codereview.chromium.org/2810193003
Cr-Commit-Position: refs/heads/master@{#464026}
Committed:
https://chromium.googlesource.com/chromium/src/+/457dcdd09c5fe44b8eb75bcdb0b7...
==========

[commit-bot: I haz the power, 2017-04-12 15:15:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/457dcdd09c5fe44b8eb75bcdb0b7...