[Payments] Change how the dialog gets destroyed.

chrome/browser/ui/views/payments/view_stack.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_VIEW_STACK_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_VIEW_STACK_H_
 
 #include "ui/views/view.h"
 #include "ui/views/animation/bounds_animator.h"
 #include "ui/views/animation/bounds_animator_observer.h"
@@ skipping 41 matching lines @@
   // Returns the top state of the stack, used in tests.
   views::View* top() { return stack_.back().get(); }
 
   void UpdateAnimatorBounds(
       views::BoundsAnimator* animator, const gfx::Rect& target);
 
   // views::BoundsAnimatorObserver:
   void OnBoundsAnimatorProgressed(views::BoundsAnimator* animator) override {}
   void OnBoundsAnimatorDone(views::BoundsAnimator* animator) override;
 
-  std::vector<std::unique_ptr<views::View>> stack_;
-
   std::unique_ptr<views::BoundsAnimator> slide_in_animator_;
   std::unique_ptr<views::BoundsAnimator> slide_out_animator_;
 
+  std::vector<std::unique_ptr<views::View>> stack_;

[Mathieu, 2017/04/12 13:29:02]

The order is important here, because views need to be destroyed before the
view-stack-wide animators and members get destroyed in reverse order. Otherwise
you'd destroy the two animators before all the views, which is wrong.

[anthonyvd, 2017/04/12 14:19:36]

Good catch, can you please add a comment about this?

[Mathieu, 2017/04/12 14:24:23]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ViewStack);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_VIEW_STACK_H_