Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: chrome/browser/ui/views/payments/view_stack.h

Issue 2810193003: [Payments] Change how the dialog gets destroyed. (Closed)
Patch Set: added comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_dialog_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/view_stack.h
diff --git a/chrome/browser/ui/views/payments/view_stack.h b/chrome/browser/ui/views/payments/view_stack.h
index 8b94104160ab1e8b66c0f4dde2f4b1299076b163..5b48c6de8c5dcbd5b102c6d8ca55a3fca10a9eec 100644
--- a/chrome/browser/ui/views/payments/view_stack.h
+++ b/chrome/browser/ui/views/payments/view_stack.h
@@ -59,11 +59,13 @@ class ViewStack : public views::BoundsAnimatorObserver,
void OnBoundsAnimatorProgressed(views::BoundsAnimator* animator) override {}
void OnBoundsAnimatorDone(views::BoundsAnimator* animator) override;
- std::vector<std::unique_ptr<views::View>> stack_;
-
std::unique_ptr<views::BoundsAnimator> slide_in_animator_;
std::unique_ptr<views::BoundsAnimator> slide_out_animator_;
+ // Should be the last member, because views need to be destroyed before other
+ // members, and members are destroyed in reverse order of their creation.
+ std::vector<std::unique_ptr<views::View>> stack_;
+
DISALLOW_COPY_AND_ASSIGN(ViewStack);
};
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_dialog_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698