Remove ListValue::Append(raw ptr) on Win

Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2809933003
Cr-Commit-Position: refs/heads/master@{#464866}
Committed: https://chromium.googlesource.com/chromium/src/+/7cc8da77161b4ab86ff43a06bda52a53f59a0bff

[vabr (Chromium), 2017-04-11 17:17:03]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 17:17:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 17:30:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 17:31:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2017-04-11 19:32:52]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 19:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 19:49:11]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[vabr (Chromium), 2017-04-12 13:11:32]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 13:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-12 13:12:31]

Description was changed from

==========
Remove ListValue::Append(raw ptr)

Step 1: ...let's see on the trybots which platforms still use it.

BUG=581865
==========

to

==========
Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
==========

[commit-bot: I haz the power, 2017-04-12 13:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 13:42:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vabr (Chromium), 2017-04-12 15:40:54]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 15:41:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-12 16:14:28]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:14:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-12 16:43:32]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:43:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-12 17:10:20]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-12 17:53:46]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:54:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-12 18:49:39]

Description was changed from

==========
Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
==========

to

==========
Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[vabr (Chromium), 2017-04-12 18:49:47]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:50:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 20:20:13]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-04-13 06:03:16]

vabr@chromium.org changed reviewers:
+ brettw@chromium.org, jdoerrie@chromium.org

[vabr (Chromium), 2017-04-13 06:03:17]

Hi Brett and Jan,

Brett -- please review //base and rubberstap the rest.

Jan -- please review the whole patch.

Thanks!
Vaclav

[jdoerrie, 2017-04-13 13:49:50]

LGTM, just nits.

https://codereview.chromium.org/2809933003/diff/160001/components/policy/core...
File components/policy/core/common/policy_loader_win_unittest.cc (right):

https://codereview.chromium.org/2809933003/diff/160001/components/policy/core...
components/policy/core/common/policy_loader_win_unittest.cc:35: #include
"base/win/registry.h"
#include "base/values.h"

https://codereview.chromium.org/2809933003/diff/160001/components/wifi/wifi_s...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/2809933003/diff/160001/components/wifi/wifi_s...
components/wifi/wifi_service_win.cc:14: #include <utility>
#include <memory>

https://codereview.chromium.org/2809933003/diff/160001/components/wifi/wifi_s...
components/wifi/wifi_service_win.cc:26: #include "base/win/registry.h"
#include "base/values.h"

https://codereview.chromium.org/2809933003/diff/160001/content/browser/tracin...
File content/browser/tracing/etw_tracing_agent_win.cc (right):

https://codereview.chromium.org/2809933003/diff/160001/content/browser/tracin...
content/browser/tracing/etw_tracing_agent_win.cc:20: #include
"content/public/browser/browser_thread.h"
#include "base/values.h"

[vabr (Chromium), 2017-04-13 16:05:08]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 16:05:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-13 16:06:48]

Thanks, Jan!

Brett, the sequence getting rid of ListValue::Append(T*) is now ready, once you
approve, it can land:
(1) https://codereview.chromium.org/2817603003/
(2) https://codereview.chromium.org/2811253004/
(3) https://codereview.chromium.org/2809933003/

Thanks!
Vaclav

https://codereview.chromium.org/2809933003/diff/160001/components/policy/core...
File components/policy/core/common/policy_loader_win_unittest.cc (right):

https://codereview.chromium.org/2809933003/diff/160001/components/policy/core...
components/policy/core/common/policy_loader_win_unittest.cc:35: #include
"base/win/registry.h"
On 2017/04/13 13:49:49, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2809933003/diff/160001/components/wifi/wifi_s...
File components/wifi/wifi_service_win.cc (right):

https://codereview.chromium.org/2809933003/diff/160001/components/wifi/wifi_s...
components/wifi/wifi_service_win.cc:14: #include <utility>
On 2017/04/13 13:49:49, jdoerrie wrote:
> #include <memory>

Done.

https://codereview.chromium.org/2809933003/diff/160001/components/wifi/wifi_s...
components/wifi/wifi_service_win.cc:26: #include "base/win/registry.h"
On 2017/04/13 13:49:49, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2809933003/diff/160001/content/browser/tracin...
File content/browser/tracing/etw_tracing_agent_win.cc (right):

https://codereview.chromium.org/2809933003/diff/160001/content/browser/tracin...
content/browser/tracing/etw_tracing_agent_win.cc:20: #include
"content/public/browser/browser_thread.h"
On 2017/04/13 13:49:49, jdoerrie wrote:
> #include "base/values.h"

Done.

[commit-bot: I haz the power, 2017-04-13 17:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 17:53:00]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-04-14 17:26:49]

lgtm

[vabr (Chromium), 2017-04-15 07:29:15]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 07:29:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 09:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 09:08:53]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-04-15 10:03:35]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-04-15 10:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdoerrie@chromium.org
Link to the patchset: https://codereview.chromium.org/2809933003/#ps180001
(title: "Includes")

[commit-bot: I haz the power, 2017-04-15 10:03:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 10:07:23]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492250615635340,
"parent_rev": "2f38a9ff1e78023cc3fa341a30448d1b9ca5a891", "commit_rev":
"7cc8da77161b4ab86ff43a06bda52a53f59a0bff"}

[commit-bot: I haz the power, 2017-04-15 10:08:17]

Description was changed from

==========
Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove ListValue::Append(raw ptr) on Win

ListValue::Append(raw ptr) is deprecated and the unique_ptr version should be
used instead. This CL achieves that on Win, which is the last platform to still
use the raw-pointer Append.

The CL also changes some related calls to DictionaryValue::Set to take
a unique_ptr instead of a raw one.

BUG=581865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2809933003
Cr-Commit-Position: refs/heads/master@{#464866}
Committed:
https://chromium.googlesource.com/chromium/src/+/7cc8da77161b4ab86ff43a06bda5...
==========

[commit-bot: I haz the power, 2017-04-15 10:08:18]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/7cc8da77161b4ab86ff43a06bda5...