Remove ListValue::Append(raw ptr) on Win

chrome/browser/win/enumerate_modules_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/win/enumerate_modules_model.h"
 
 #include <softpub.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <tlhelp32.h>
 #include <wincrypt.h>
 #include <wintrust.h>
 #include <mscat.h>  // NOLINT: This must be after wincrypt and wintrust.
 
 #include <algorithm>
 #include <set>
 #include <string>
+#include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/debug/leak_annotations.h"
 #include "base/environment.h"
 #include "base/file_version_info.h"
 #include "base/i18n/case_conversion.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/scoped_generic.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task_scheduler/post_task.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "base/win/registry.h"
@@ skipping 562 matching lines @@
     return nullptr;
 
   if (enumerated_modules_.empty())
     return nullptr;
 
   base::ListValue* list = new base::ListValue();
 
   for (ModuleEnumerator::ModulesVector::const_iterator module =
            enumerated_modules_.begin();
        module != enumerated_modules_.end(); ++module) {
-    base::DictionaryValue* data = new base::DictionaryValue();
+    auto data = base::MakeUnique<base::DictionaryValue>();
     data->SetInteger("type", module->type);
     base::string16 type_string;
     if ((module->type & ModuleEnumerator::LOADED_MODULE) == 0) {
       // Module is not loaded, denote type of module.
       if (module->type & ModuleEnumerator::SHELL_EXTENSION)
         type_string = L"Shell Extension";
       if (module->type & ModuleEnumerator::WINSOCK_MODULE_REGISTRATION) {
         if (!type_string.empty())
           type_string += L", ";
         type_string += L"Winsock";
@@ skipping 43 matching lines @@
     base::string16 possible_resolution;
     if (!actions.empty()) {
       possible_resolution =
           l10n_util::GetStringUTF16(IDS_CONFLICTS_CHECK_POSSIBLE_ACTIONS) +
           L" " + actions;
     }
     data->SetString("possibleResolution", possible_resolution);
     // TODO(chrisha): Set help_url when we have a meaningful place for users
     // to land.
 
-    list->Append(data);
+    list->Append(std::move(data));
   }
 
   return list;
 }
 
 GURL EnumerateModulesModel::GetConflictUrl() {
   // For now, simply bring up the chrome://conflicts page, which has detailed
   // information about each module.
   if (ShouldShowConflictWarning())
     return GURL(L"chrome://conflicts");
@@ skipping 35 matching lines @@
 
   UMA_HISTOGRAM_COUNTS_100("Conflicts.SuspectedBadModules",
                            suspected_bad_modules_detected_);
   UMA_HISTOGRAM_COUNTS_100("Conflicts.ConfirmedBadModules",
                            confirmed_bad_modules_detected_);
 
   // Forward the callback to any registered observers.
   for (Observer& observer : observers_)
     observer.OnScanCompleted();
 }