Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2808883002: [Payments] Fix bug in shipping option selection. (Closed)

Created:
3 years, 8 months ago by Mathieu
Modified:
3 years, 8 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Fix bug in shipping option selection. The code was not handling a shipping option going away very well. BUG=707240 TEST=browser_tests Review-Url: https://codereview.chromium.org/2808883002 Cr-Commit-Position: refs/heads/master@{#463306} Committed: https://chromium.googlesource.com/chromium/src/+/281faa09393f7448e894309581d531429abb4fa1

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -23 lines) Patch
M chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.cc View 2 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_option_view_controller.h View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_option_view_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/payments/content/payment_request_spec.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Mathieu
Hi, PTAL!
3 years, 8 months ago (2017-04-10 15:45:44 UTC) #3
anthonyvd
lgtm
3 years, 8 months ago (2017-04-10 16:04:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808883002/20001
3 years, 8 months ago (2017-04-10 16:11:46 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:23:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/281faa09393f7448e894309581d5...

Powered by Google App Engine
This is Rietveld 408576698