Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4805)

Unified Diff: chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

Issue 2808883002: [Payments] Fix bug in shipping option selection. (Closed)
Patch Set: Initial Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc b/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
index bcac6123e56e34d1176e695a47cd7b1e15be9339..94b9cddfb3d23d572e8e45074daea50760e1a00c 100644
--- a/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
+++ b/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
@@ -111,9 +111,14 @@ void PaymentRequestBrowserTestBase::OnPaymentMethodOpened() {
event_observer_->Observe(DialogEvent::PAYMENT_METHOD_OPENED);
}
-void PaymentRequestBrowserTestBase::OnShippingSectionOpened() {
+void PaymentRequestBrowserTestBase::OnShippingAddressSectionOpened() {
if (event_observer_)
- event_observer_->Observe(DialogEvent::SHIPPING_SECTION_OPENED);
+ event_observer_->Observe(DialogEvent::SHIPPING_ADDRESS_SECTION_OPENED);
+}
+
+void PaymentRequestBrowserTestBase::OnShippingOptionSectionOpened() {
+ if (event_observer_)
+ event_observer_->Observe(DialogEvent::SHIPPING_OPTION_SECTION_OPENED);
}
void PaymentRequestBrowserTestBase::OnCreditCardEditorOpened() {
@@ -206,12 +211,18 @@ void PaymentRequestBrowserTestBase::OpenPaymentMethodScreen() {
ClickOnDialogViewAndWait(DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION);
}
-void PaymentRequestBrowserTestBase::OpenShippingSectionScreen() {
- ResetEventObserver(DialogEvent::SHIPPING_SECTION_OPENED);
+void PaymentRequestBrowserTestBase::OpenShippingAddressSectionScreen() {
+ ResetEventObserver(DialogEvent::SHIPPING_ADDRESS_SECTION_OPENED);
- ClickOnDialogViewAndWait(DialogViewID::PAYMENT_SHEET_SHIPPING_SECTION);
+ ClickOnDialogViewAndWait(
+ DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION);
}
+void PaymentRequestBrowserTestBase::OpenShippingOptionSectionScreen() {
+ ResetEventObserver(DialogEvent::SHIPPING_OPTION_SECTION_OPENED);
+
+ ClickOnDialogViewAndWait(DialogViewID::PAYMENT_SHEET_SHIPPING_OPTION_SECTION);
+}
void PaymentRequestBrowserTestBase::OpenCreditCardEditorScreen() {
ResetEventObserver(DialogEvent::CREDIT_CARD_EDITOR_OPENED);

Powered by Google App Engine
This is Rietveld 408576698