chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc - Issue 2808883002: [Payments] Fix bug in shipping option selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc

Issue 2808883002: [Payments] Fix bug in shipping option selection. (Closed)

Patch Set: Initial Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/payment_sheet_view_controller.cc ('k') | chrome/browser/ui/views/payments/shipping_option_view_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc

index d8ecdb9c51cb9622f9a0c1aeb2ac580081d8cc3a..76efc95d5aaf368e1c5e23ad1a22b6e48fc1b59c 100644

--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc

@@ -62,8 +62,11 @@ IN_PROC_BROWSER_TEST_F(PaymentSheetViewControllerNoShippingTest,

DialogViewID::PAYMENT_SHEET_SUMMARY_SECTION)));

EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(

DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION)));

+ EXPECT_EQ(nullptr,

+ dialog_view()->GetViewByID(static_cast<int>(

+ DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION)));

EXPECT_EQ(nullptr, dialog_view()->GetViewByID(static_cast<int>(

- DialogViewID::PAYMENT_SHEET_SHIPPING_SECTION)));

+ DialogViewID::PAYMENT_SHEET_SHIPPING_OPTION_SECTION)));

EXPECT_EQ(nullptr, dialog_view()->GetViewByID(static_cast<int>(

DialogViewID::PAYMENT_SHEET_CONTACT_INFO_SECTION)));

}

@@ -145,8 +148,11 @@ IN_PROC_BROWSER_TEST_F(PaymentSheetViewControllerContactDetailsTest,

DialogViewID::PAYMENT_SHEET_SUMMARY_SECTION)));

EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(

DialogViewID::PAYMENT_SHEET_PAYMENT_METHOD_SECTION)));

+ EXPECT_NE(nullptr,

+ dialog_view()->GetViewByID(static_cast<int>(

+ DialogViewID::PAYMENT_SHEET_SHIPPING_ADDRESS_SECTION)));

EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(

- DialogViewID::PAYMENT_SHEET_SHIPPING_SECTION)));

+ DialogViewID::PAYMENT_SHEET_SHIPPING_OPTION_SECTION)));

EXPECT_NE(nullptr, dialog_view()->GetViewByID(static_cast<int>(

DialogViewID::PAYMENT_SHEET_CONTACT_INFO_SECTION)));

}