Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2808533002: [heap] Reland "Remove size specializations in static object visitors. (patchset #4 id:60001 of http… (Closed)

Created:
3 years, 8 months ago by ulan
Modified:
3 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Remove size specializations in static object visitors. (patchset #4 id:60001 of https://codereview.chromium.org/2763413007/ )" This reverts commit 61df2d90a952066cec6eb20fc0602b5fae749874. The CL was speculatively reverted due to canary crashes, which turned out to be caused by another CL. Original issue's description: > [heap] Remove size specializations in static object visitors. > > Apart from that this patch adds kVisitJSObjectFast for JSObjects that > do not have any unboxed double fields and can be visited without > run-time layout check. > > BUG=chromium:694255 > > Review-Url: https://codereview.chromium.org/2763413007 > Cr-Commit-Position: refs/heads/master@{#44237} > Committed: https://chromium.googlesource.com/v8/v8/+/dbb1cbe3a85d5c5528ce876d905e78d2ab35f00b Review-Url: https://codereview.chromium.org/2808533002 Cr-Commit-Position: refs/heads/master@{#44494} Committed: https://chromium.googlesource.com/v8/v8/+/e86d3a2ac65c336c3c611336de1ea4773495b5cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -148 lines) Patch
M src/heap/objects-visiting.h View 8 chunks +12 lines, -109 lines 0 comments Download
M src/heap/objects-visiting.cc View 4 chunks +6 lines, -14 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +10 lines, -16 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ulan
ptal
3 years, 8 months ago (2017-04-07 19:15:38 UTC) #2
Michael Lippautz
lgtm
3 years, 8 months ago (2017-04-07 19:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808533002/1
3 years, 8 months ago (2017-04-07 19:19:35 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 19:54:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e86d3a2ac65c336c3c611336de1ea477349...

Powered by Google App Engine
This is Rietveld 408576698