Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2763413007: [heap] Remove size specializations in static object visitors. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove size specializations in static object visitors. Apart from that this patch adds kVisitJSObjectFast for JSObjects that do not have any unboxed double fields and can be visited without run-time layout check. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2763413007 Cr-Commit-Position: refs/heads/master@{#44237} Committed: https://chromium.googlesource.com/v8/v8/+/dbb1cbe3a85d5c5528ce876d905e78d2ab35f00b

Patch Set 1 #

Patch Set 2 : rename #

Patch Set 3 : rebase #

Patch Set 4 : fast body descriptor for js objects #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -148 lines) Patch
M src/heap/objects-visiting.h View 1 8 chunks +12 lines, -109 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 4 chunks +6 lines, -14 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 chunks +10 lines, -16 lines 0 comments Download
M src/heap/scavenger.cc View 1 1 chunk +10 lines, -9 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 2 3 1 chunk +25 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
ulan
ptal
3 years, 9 months ago (2017-03-24 14:41:22 UTC) #3
ulan
Added faster version of SizeOf, which is important for scavenger. https://codereview.chromium.org/2763413007/diff/60001/src/objects-body-descriptors-inl.h File src/objects-body-descriptors-inl.h (right): https://codereview.chromium.org/2763413007/diff/60001/src/objects-body-descriptors-inl.h#newcode134 ...
3 years, 9 months ago (2017-03-27 11:23:24 UTC) #5
ulan
ping
3 years, 8 months ago (2017-03-29 14:46:41 UTC) #6
Michael Lippautz
lgtm
3 years, 8 months ago (2017-03-29 14:54:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413007/60001
3 years, 8 months ago (2017-03-29 14:55:43 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/v8/v8/+/dbb1cbe3a85d5c5528ce876d905e78d2ab35f00b
3 years, 8 months ago (2017-03-29 15:21:55 UTC) #12
ulan
3 years, 8 months ago (2017-04-06 18:55:05 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2800923004/ by ulan@chromium.org.

The reason for reverting is: Speculative revert due to canary crashes.

BUG=chromium:708339,chromium:707790.

Powered by Google App Engine
This is Rietveld 408576698