[heap] Reland "Remove size specializations in static object visitors. (patchset #4 id:60001 of http…

src/heap/objects-visiting.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/objects-visiting.h"
 
 #include "src/heap/heap-inl.h"
 #include "src/heap/mark-compact-inl.h"
 #include "src/heap/objects-visiting-inl.h"
 
@@ skipping 22 matching lines @@
         if (IsShortcutCandidate(instance_type)) {
           return kVisitShortcutCandidate;
         } else {
           return kVisitConsString;
         }
 
       case kSlicedStringTag:
         return kVisitSlicedString;
 
       case kExternalStringTag:
-        return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
-                                   instance_size, has_unboxed_fields);
+        return kVisitDataObject;
 
       case kThinStringTag:
         return kVisitThinString;
     }
     UNREACHABLE();
   }
 
   switch (instance_type) {
     case BYTE_ARRAY_TYPE:
       return kVisitByteArray;
@@ skipping 35 matching lines @@
     case JS_WEAK_SET_TYPE:
       return kVisitJSWeakCollection;
 
     case JS_REGEXP_TYPE:
       return kVisitJSRegExp;
 
     case SHARED_FUNCTION_INFO_TYPE:
       return kVisitSharedFunctionInfo;
 
     case JS_PROXY_TYPE:
-      return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
-                                 instance_size, has_unboxed_fields);
+      return kVisitStruct;
 
     case SYMBOL_TYPE:
       return kVisitSymbol;
 
     case JS_ARRAY_BUFFER_TYPE:
       return kVisitJSArrayBuffer;
 
     case JS_OBJECT_TYPE:
     case JS_ERROR_TYPE:
     case JS_ARGUMENTS_TYPE:
@@ skipping 48 matching lines @@
     case JS_FAST_HOLEY_SMI_ARRAY_VALUE_ITERATOR_TYPE:
     case JS_FAST_ARRAY_VALUE_ITERATOR_TYPE:
     case JS_FAST_HOLEY_ARRAY_VALUE_ITERATOR_TYPE:
     case JS_FAST_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE:
     case JS_FAST_HOLEY_DOUBLE_ARRAY_VALUE_ITERATOR_TYPE:
     case JS_GENERIC_ARRAY_VALUE_ITERATOR_TYPE:
 
     case JS_PROMISE_CAPABILITY_TYPE:
     case JS_PROMISE_TYPE:
     case JS_BOUND_FUNCTION_TYPE:
-      return GetVisitorIdForSize(kVisitJSObject, kVisitJSObjectGeneric,
-                                 instance_size, has_unboxed_fields);
+      return has_unboxed_fields ? kVisitJSObject : kVisitJSObjectFast;
     case JS_API_OBJECT_TYPE:
     case JS_SPECIAL_API_OBJECT_TYPE:
-      return GetVisitorIdForSize(kVisitJSApiObject, kVisitJSApiObjectGeneric,
-                                 instance_size, has_unboxed_fields);
+      return kVisitJSApiObject;
 
     case JS_FUNCTION_TYPE:
       return kVisitJSFunction;
 
     case FILLER_TYPE:
-      if (instance_size == kPointerSize) return kVisitDataObjectGeneric;
-    // Fall through.
     case FOREIGN_TYPE:
     case HEAP_NUMBER_TYPE:
     case MUTABLE_HEAP_NUMBER_TYPE:
-      return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
-                                 instance_size, has_unboxed_fields);
+      return kVisitDataObject;
 
     case FIXED_UINT8_ARRAY_TYPE:
     case FIXED_INT8_ARRAY_TYPE:
     case FIXED_UINT16_ARRAY_TYPE:
     case FIXED_INT16_ARRAY_TYPE:
     case FIXED_UINT32_ARRAY_TYPE:
     case FIXED_INT32_ARRAY_TYPE:
     case FIXED_FLOAT32_ARRAY_TYPE:
     case FIXED_UINT8_CLAMPED_ARRAY_TYPE:
       return kVisitFixedTypedArray;
 
     case FIXED_FLOAT64_ARRAY_TYPE:
       return kVisitFixedFloat64Array;
 
 #define MAKE_STRUCT_CASE(NAME, Name, name) case NAME##_TYPE:
       STRUCT_LIST(MAKE_STRUCT_CASE)
 #undef MAKE_STRUCT_CASE
       if (instance_type == ALLOCATION_SITE_TYPE) {
         return kVisitAllocationSite;
       }
 
-      return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
-                                 instance_size, has_unboxed_fields);
+      return kVisitStruct;
 
     default:
       UNREACHABLE();
       return kVisitorIdCount;
   }
 }
 
 
 // We don't record weak slots during marking or scavenges. Instead we do it
 // once when we complete mark-compact cycle.  Note that write barrier has no
@@ skipping 181 matching lines @@
 };
 
 
 template Object* VisitWeakList<Context>(Heap* heap, Object* list,
                                         WeakObjectRetainer* retainer);
 
 template Object* VisitWeakList<AllocationSite>(Heap* heap, Object* list,
                                                WeakObjectRetainer* retainer);
 }  // namespace internal
 }  // namespace v8