Improve tests for Mixed-Case JIDs.

Improve tests for Mixed-Case JIDs.

1. FakeAuthenticator now verifies that correct IDs are passed on both
ends of the connection.
2. All tests in JingleSessionTest now use mixed-case JIDs.

BUG=707833
Review-Url: https://codereview.chromium.org/2808283002
Cr-Commit-Position: refs/heads/master@{#463833}
Committed: https://chromium.googlesource.com/chromium/src/+/65aaa85ee5c1ff86742d9a426348afc7be78568e

[Sergey Ulanov, 2017-04-11 00:47:09]

Description was changed from

==========
Improve tests for Mixed-Case JIDs.

1. FakeAuthenticator now verifies that correct IDs are passed on both
ends of the connection.
2. All tests in JingleSessionTest now use mixed-case JIDs.
==========

to

==========
Improve tests for Mixed-Case JIDs.

1. FakeAuthenticator now verifies that correct IDs are passed on both
ends of the connection.
2. All tests in JingleSessionTest now use mixed-case JIDs.

BUG=707833
==========

[Sergey Ulanov, 2017-04-11 00:47:09]

sergeyu@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2017-04-11 16:20:34]

lgtm

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_...
File remoting/protocol/fake_authenticator.h (right):

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_...
remoting/protocol/fake_authenticator.h:130: FakeAuthenticator::Config config);
nit: Config struct passed by const ref?

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/jingl...
File remoting/protocol/jingle_session_unittest.cc (right):

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/jingl...
remoting/protocol/jingle_session_unittest.cc:58: // kHostJid the way it would be
store din the directory.
s/store din/stored in

[Sergey Ulanov, 2017-04-11 21:14:20]

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_...
File remoting/protocol/fake_authenticator.h (right):

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/fake_...
remoting/protocol/fake_authenticator.h:130: FakeAuthenticator::Config config);
On 2017/04/11 16:20:34, joedow wrote:
> nit: Config struct passed by const ref?

That struct is only 12 bytes, not much bigger than a pointer, so I don't think
passing it by reference would make any difference.

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/jingl...
File remoting/protocol/jingle_session_unittest.cc (right):

https://codereview.chromium.org/2808283002/diff/20001/remoting/protocol/jingl...
remoting/protocol/jingle_session_unittest.cc:58: // kHostJid the way it would be
store din the directory.
On 2017/04/11 16:20:34, joedow wrote:
> s/store din/stored in

Done.

[Sergey Ulanov, 2017-04-11 21:14:35]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-04-11 21:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2808283002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-04-11 21:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 21:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:33:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2017-04-11 22:37:33]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-04-11 22:37:34]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2808283002/#ps60001
(title: "fix tests")

[commit-bot: I haz the power, 2017-04-11 22:38:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:26:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491950253909650,
"parent_rev": "bee3ee052611a8a3c8e64b9ceb9bb9f7c9a74496", "commit_rev":
"65aaa85ee5c1ff86742d9a426348afc7be78568e"}

[commit-bot: I haz the power, 2017-04-11 23:27:16]

Description was changed from

==========
Improve tests for Mixed-Case JIDs.

1. FakeAuthenticator now verifies that correct IDs are passed on both
ends of the connection.
2. All tests in JingleSessionTest now use mixed-case JIDs.

BUG=707833
==========

to

==========
Improve tests for Mixed-Case JIDs.

1. FakeAuthenticator now verifies that correct IDs are passed on both
ends of the connection.
2. All tests in JingleSessionTest now use mixed-case JIDs.

BUG=707833

Review-Url: https://codereview.chromium.org/2808283002
Cr-Commit-Position: refs/heads/master@{#463833}
Committed:
https://chromium.googlesource.com/chromium/src/+/65aaa85ee5c1ff86742d9a426348...
==========

[commit-bot: I haz the power, 2017-04-11 23:27:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/65aaa85ee5c1ff86742d9a426348...