Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 8 months ago
Reviewers:
tkent, chrishtr
CC:
ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/graphics BUG=707658 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2807923002 Cr-Commit-Position: refs/heads/master@{#463903} Committed: https://chromium.googlesource.com/chromium/src/+/94e9d9cf0302323949e90805222c8aa342b53641

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics #

Patch Set 4 : Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics #

Total comments: 22

Patch Set 5 : rebase and fix #

Total comments: 2

Patch Set 6 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -158 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorSpace.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContextStateSaver.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.cpp View 1 2 3 4 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp View 1 2 3 4 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp View 1 2 3 4 6 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageOrientation.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/InterceptingCanvas.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp View 1 2 3 4 16 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintInvalidationReason.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.cpp View 1 2 3 4 3 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ProfilingCanvas.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 1 2 3 4 22 chunks +33 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 77 (65 generated)
chrishtr
lgtm
3 years, 8 months ago (2017-04-08 18:26:52 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807923002/60001
3 years, 8 months ago (2017-04-08 22:58:25 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/267803)
3 years, 8 months ago (2017-04-09 01:51:12 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807923002/60001
3 years, 8 months ago (2017-04-09 10:36:28 UTC) #42
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-09 22:03:58 UTC) #44
tkent
https://codereview.chromium.org/2807923002/diff/60001/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp File third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp (right): https://codereview.chromium.org/2807923002/diff/60001/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp#newcode98 third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp:98: DCHECK(WTF::isMainThread() && data.isEmpty()); Split this into two DCHECKs. https://codereview.chromium.org/2807923002/diff/60001/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp#newcode104 ...
3 years, 8 months ago (2017-04-09 23:17:28 UTC) #45
Hwanseung Lee
@tkent PTAL, thank you. https://codereview.chromium.org/2807923002/diff/60001/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp File third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp (right): https://codereview.chromium.org/2807923002/diff/60001/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp#newcode98 third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp:98: DCHECK(WTF::isMainThread() && data.isEmpty()); On 2017/04/09 ...
3 years, 8 months ago (2017-04-11 22:24:10 UTC) #58
tkent
https://codereview.chromium.org/2807923002/diff/120001/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp File third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp (right): https://codereview.chromium.org/2807923002/diff/120001/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp#newcode317 third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:317: DCHECK_GE(decoded_size.height(), 0); Should be DCHECK_GT, not DCHCK_GE
3 years, 8 months ago (2017-04-11 22:43:25 UTC) #59
Hwanseung Lee
@tkent i fixed it. thank you. https://codereview.chromium.org/2807923002/diff/120001/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp File third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp (right): https://codereview.chromium.org/2807923002/diff/120001/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp#newcode317 third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp:317: DCHECK_GE(decoded_size.height(), 0); On ...
3 years, 8 months ago (2017-04-11 22:52:21 UTC) #65
tkent
lgtm
3 years, 8 months ago (2017-04-11 23:48:29 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807923002/140001
3 years, 8 months ago (2017-04-12 02:14:13 UTC) #74
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 02:27:21 UTC) #77
Message was sent while issue was closed.
Committed patchset #6 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/94e9d9cf0302323949e90805222c...

Powered by Google App Engine
This is Rietveld 408576698