Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

third_party/WebKit/Source/platform/graphics/Path.cpp

 /*
  * Copyright (C) 2003, 2006 Apple Computer, Inc.  All rights reserved.
  *                     2006 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 346 matching lines @@
 void Path::closeSubpath() {
   m_path.close();
 }
 
 void Path::addEllipse(const FloatPoint& p,
                       float radiusX,
                       float radiusY,
                       float startAngle,
                       float endAngle,
                       bool anticlockwise) {
-  ASSERT(ellipseIsRenderable(startAngle, endAngle));
-  ASSERT(startAngle >= 0 && startAngle < twoPiFloat);
-  ASSERT((anticlockwise && (startAngle - endAngle) >= 0) ||
+#if DCHECK_IS_ON()
+  DCHECK(ellipseIsRenderable(startAngle, endAngle));
+#endif
+  DCHECK(startAngle >= 0 && startAngle < twoPiFloat);

[tkent, 2017/04/09 23:17:27]

Split this into two DCHECKs.

[Hwanseung Lee, 2017/04/11 22:24:10]

Done.

+  DCHECK((anticlockwise && (startAngle - endAngle) >= 0) ||
          (!anticlockwise && (endAngle - startAngle) >= 0));
 
   SkScalar cx = WebCoreFloatToSkScalar(p.x());
   SkScalar cy = WebCoreFloatToSkScalar(p.y());
   SkScalar radiusXScalar = WebCoreFloatToSkScalar(radiusX);
   SkScalar radiusYScalar = WebCoreFloatToSkScalar(radiusY);
 
   SkRect oval;
   oval.set(cx - radiusXScalar, cy - radiusYScalar, cx + radiusXScalar,
            cy + radiusYScalar);
@@ skipping 38 matching lines @@
   m_path.addRect(rect, SkPath::kCW_Direction, 0);
 }
 
 void Path::addEllipse(const FloatPoint& p,
                       float radiusX,
                       float radiusY,
                       float rotation,
                       float startAngle,
                       float endAngle,
                       bool anticlockwise) {
-  ASSERT(ellipseIsRenderable(startAngle, endAngle));
-  ASSERT(startAngle >= 0 && startAngle < twoPiFloat);
-  ASSERT((anticlockwise && (startAngle - endAngle) >= 0) ||
+#if DCHECK_IS_ON()
+  DCHECK(ellipseIsRenderable(startAngle, endAngle));
+#endif
+  DCHECK(startAngle >= 0 && startAngle < twoPiFloat);

[tkent, 2017/04/09 23:17:27]

Split this into two DCHECKs.

[Hwanseung Lee, 2017/04/11 22:24:10]

Done.

+  DCHECK((anticlockwise && (startAngle - endAngle) >= 0) ||
          (!anticlockwise && (endAngle - startAngle) >= 0));
 
   if (!rotation) {
     addEllipse(FloatPoint(p.x(), p.y()), radiusX, radiusY, startAngle, endAngle,
                anticlockwise);
     return;
   }
 
   // Add an arc after the relevant transform.
   AffineTransform ellipseTransform =
       AffineTransform::translation(p.x(), p.y()).rotateRadians(rotation);
-  ASSERT(ellipseTransform.isInvertible());
+  DCHECK(ellipseTransform.isInvertible());
   AffineTransform inverseEllipseTransform = ellipseTransform.inverse();
   transform(inverseEllipseTransform);
   addEllipse(FloatPoint::zero(), radiusX, radiusY, startAngle, endAngle,
              anticlockwise);
   transform(ellipseTransform);
 }
 
 void Path::addEllipse(const FloatRect& rect) {
   // Start at 3 o'clock, add clock-wise.
   m_path.addOval(rect, SkPath::kCW_Direction, 1);
@@ skipping 92 matching lines @@
 }
 
 #if DCHECK_IS_ON()
 bool ellipseIsRenderable(float startAngle, float endAngle) {
   return (std::abs(endAngle - startAngle) < twoPiFloat) ||
          WebCoreFloatNearlyEqual(std::abs(endAngle - startAngle), twoPiFloat);
 }
 #endif
 
 }  // namespace blink