Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/ContiguousContainer.h"
 
 #include <algorithm>
 #include <memory>
 #include "platform/wtf/Allocator.h"
 #include "platform/wtf/ContainerAnnotations.h"
@@ skipping 22 matching lines @@
     ANNOTATE_DELETE_BUFFER(m_begin, m_capacity, usedCapacity());
     WTF::Partitions::bufferFree(m_begin);
   }
 
   size_t capacity() const { return m_capacity; }
   size_t usedCapacity() const { return m_end - m_begin; }
   size_t unusedCapacity() const { return capacity() - usedCapacity(); }
   bool isEmpty() const { return usedCapacity() == 0; }
 
   void* allocate(size_t objectSize) {
-    ASSERT(unusedCapacity() >= objectSize);
+    DCHECK_GE(unusedCapacity(), objectSize);
     ANNOTATE_CHANGE_SIZE(m_begin, m_capacity, usedCapacity(),
                          usedCapacity() + objectSize);
     void* result = m_end;
     m_end += objectSize;
     return result;
   }
 
   void deallocateLastObject(void* object) {
-    RELEASE_ASSERT(m_begin <= object && object < m_end);
+    CHECK(m_begin <= object && object < m_end);

[tkent, 2017/04/09 23:17:27]

Split this into two CHECKs.

[Hwanseung Lee, 2017/04/11 22:24:10]

Done.

     ANNOTATE_CHANGE_SIZE(m_begin, m_capacity, usedCapacity(),
                          static_cast<char*>(object) - m_begin);
     m_end = static_cast<char*>(object);
   }
 
  private:
   // m_begin <= m_end <= m_begin + m_capacity
   char* m_begin;
   char* m_end;
   size_t m_capacity;
@@ skipping 35 matching lines @@
          m_elements.capacity() * sizeof(m_elements[0]);
 }
 
 void ContiguousContainerBase::reserveInitialCapacity(size_t bufferSize,
                                                      const char* typeName) {
   allocateNewBufferForNextAllocation(bufferSize, typeName);
 }
 
 void* ContiguousContainerBase::allocate(size_t objectSize,
                                         const char* typeName) {
-  ASSERT(objectSize <= m_maxObjectSize);
+  DCHECK_LE(objectSize, m_maxObjectSize);
 
   Buffer* bufferForAlloc = nullptr;
   if (!m_buffers.isEmpty()) {
     Buffer* endBuffer = m_buffers[m_endIndex].get();
     if (endBuffer->unusedCapacity() >= objectSize)
       bufferForAlloc = endBuffer;
     else if (m_endIndex + 1 < m_buffers.size())
       bufferForAlloc = m_buffers[++m_endIndex].get();
   }
 
@@ skipping 42 matching lines @@
   while (m_endIndex < m_buffers.size() - 1) {
     DCHECK(m_buffers.back()->isEmpty());
     m_buffers.pop_back();
   }
 }
 
 ContiguousContainerBase::Buffer*
 ContiguousContainerBase::allocateNewBufferForNextAllocation(
     size_t bufferSize,
     const char* typeName) {
-  ASSERT(m_buffers.isEmpty() || m_endIndex == m_buffers.size() - 1);
+  DCHECK(m_buffers.isEmpty() || m_endIndex == m_buffers.size() - 1);
   std::unique_ptr<Buffer> newBuffer =
       WTF::makeUnique<Buffer>(bufferSize, typeName);
   Buffer* bufferToReturn = newBuffer.get();
   m_buffers.push_back(std::move(newBuffer));
   m_endIndex = m_buffers.size() - 1;
   return bufferToReturn;
 }
 
 }  // namespace blink