Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
index ce6839e6e44144f7c8d13445d6dc82705f2122b0..f50358616c914d66bd0840a3d67973838dd0827d 100644
--- a/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
+++ b/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
@@ -105,7 +105,7 @@ FontCache::FontCache() : m_purgePreventCount(0) {
m_fontManager = sk_ref_sp(s_staticFontManager);
if (!m_fontManager)
m_fontManager = SkFontMgr_New_DirectWrite();
- ASSERT(m_fontManager.get());
+ DCHECK(m_fontManager.get());
}
// Given the desired base font, this will create a SimpleFontData for a specific
@@ -326,7 +326,7 @@ std::unique_ptr<FontPlatformData> FontCache::createFontPlatformData(
const FontFaceCreationParams& creationParams,
float fontSize,
AlternateFontName alternateFontName) {
- ASSERT(creationParams.creationType() == CreateFontByFamily);
+ DCHECK_EQ(creationParams.creationType(), CreateFontByFamily);
CString name;
sk_sp<SkTypeface> tf = createTypeface(fontDescription, creationParams, name);

Powered by Google App Engine
This is Rietveld 408576698