third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

index dde7aebf8f03e4bf121761af34dfdb088d9e6b8e..ed4edb10d8d01541b0d7792f7dbbc5c05bd10b74 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h

@@ -70,7 +70,7 @@ class ShapeCache {

unsigned short length,

TextDirection direction)

: m_length(length), m_direction(static_cast<unsigned>(direction)) {

- ASSERT(length <= s_capacity);

+ DCHECK(length <= s_capacity);

tkent 2017/04/09 23:13:23 Use DCHECK_LE

Hwanseung Lee 2017/04/11 22:25:09 it was cause of build fail. so i did not change.

StringHasher hasher;