third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp b/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

index 8626e94ff41ba6a12da87e8bf7dec97684edd7ec..757bd9f91b308c83c8f6a41872ff1547dc43142f 100644

--- a/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

+++ b/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

@@ -84,7 +84,7 @@ AtomicString FontCache::getFamilyNameForCharacter(

UChar32 c,

const FontDescription& fontDescription,

FontFallbackPriority fallbackPriority) {

- ASSERT(fm);

+ DCHECK(fm);

const size_t kMaxLocales = 4;

const char* bcp47Locales[kMaxLocales];

@@ -202,7 +202,7 @@ PassRefPtr<SimpleFontData> FontCache::getLastResortFallbackFont(

}

#endif

- ASSERT(fontPlatformData);

+ DCHECK(fontPlatformData);

return fontDataFromFontPlatformData(fontPlatformData, shouldRetain);

}