Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp b/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp
index 3015ae4e08d89a84a36d3e3edf892e7b00f843e3..cab9b9a5119cc6a97b33304623a0cd025c8426c9 100644
--- a/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp
+++ b/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp
@@ -448,7 +448,7 @@ const UChar* getFontFamilyForScript(UScriptCode script,
if (script == USCRIPT_INVALID_CODE)
return 0;
- ASSERT(script < USCRIPT_CODE_LIMIT);
+ DCHECK_LT(script, USCRIPT_CODE_LIMIT);
if (generic == FontDescription::MonospaceFamily) {
const UChar* monospaceFamily = findMonospaceFontForScript(script);
if (monospaceFamily)
@@ -473,8 +473,8 @@ const UChar* getFallbackFamily(UChar32 character,
UScriptCode* scriptChecked,
FontFallbackPriority fallbackPriority,
SkFontMgr* fontManager) {
- ASSERT(character);
- ASSERT(fontManager);
+ DCHECK(character);
+ DCHECK(fontManager);
UBlockCode block = fallbackPriority == FontFallbackPriority::EmojiEmoji
? UBLOCK_EMOTICONS
: ublock_getCode(character);

Powered by Google App Engine
This is Rietveld 408576698