Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2807593003: Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)

Created:
3 years, 8 months ago by hongchan
Modified:
3 years, 8 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews, kinuko+watch, Raymond Toy, mac-reviews_chromium.org, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (patchset #3 id:40001 of https://codereview.chromium.org/2803073002/ ) Reason for revert: Unexpected compilation error from buildbot Android Builder. Original issue's description: > Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio > > This CL is the second part of the conversion. It manually replaces: > > - RELEASE_ASSERT() with CHECK(). > - ASSERT(...args) with one or more DCHECK_op(arg). > > With this CL the following script returns 0 result. > > ``` > cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio > grep -rnw . -e 'ASSERT(' > ``` > > BUG=707655 > > Review-Url: https://codereview.chromium.org/2803073002 > Cr-Commit-Position: refs/heads/master@{#462904} > Committed: https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea37ce7f6a801d5 TBR=rtoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707655 Review-Url: https://codereview.chromium.org/2807593003 Cr-Commit-Position: refs/heads/master@{#462908} Committed: https://chromium.googlesource.com/chromium/src/+/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -66 lines) Patch
M third_party/WebKit/Source/platform/audio/AudioArray.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioBus.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioDelayDSPKernel.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioResamplerKernel.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioUtilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/DirectConvolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFElevation.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFKernel.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFPanner.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/IIRFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/MultiChannelResampler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/SincResampler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/ipp/FFTFrameIPP.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/mac/FFTFrameMac.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hongchan
Created Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio
3 years, 8 months ago (2017-04-07 17:28:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807593003/1
3 years, 8 months ago (2017-04-07 17:28:52 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:30:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4f0f6a6669b6bae15bb348d5a0b...

Powered by Google App Engine
This is Rietveld 408576698