CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1491586083954350, "parent_rev": "5717606707c4bdae7710dc382b3f687e713830f9", "commit_rev": "b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019"}
3 years, 8 months ago
(2017-04-07 17:30:02 UTC)
#4
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491586083954350, "parent_rev":
"5717606707c4bdae7710dc382b3f687e713830f9", "commit_rev":
"b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019"}
commit-bot: I haz the power
Description was changed from ========== Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (patchset #3 ...
3 years, 8 months ago
(2017-04-07 17:30:47 UTC)
#5
Message was sent while issue was closed.
Description was changed from
==========
Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in
platform/audio (patchset #3 id:40001 of
https://codereview.chromium.org/2803073002/ )
Reason for revert:
Unexpected compilation error from buildbot Android Builder.
Original issue's description:
> Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in
platform/audio
>
> This CL is the second part of the conversion. It manually replaces:
>
> - RELEASE_ASSERT() with CHECK().
> - ASSERT(...args) with one or more DCHECK_op(arg).
>
> With this CL the following script returns 0 result.
>
> ```
> cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
> grep -rnw . -e 'ASSERT('
> ```
>
> BUG=707655
>
> Review-Url: https://codereview.chromium.org/2803073002
> Cr-Commit-Position: refs/heads/master@{#462904}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...TBR=rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707655
==========
to
==========
Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in
platform/audio (patchset #3 id:40001 of
https://codereview.chromium.org/2803073002/ )
Reason for revert:
Unexpected compilation error from buildbot Android Builder.
Original issue's description:
> Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in
platform/audio
>
> This CL is the second part of the conversion. It manually replaces:
>
> - RELEASE_ASSERT() with CHECK().
> - ASSERT(...args) with one or more DCHECK_op(arg).
>
> With this CL the following script returns 0 result.
>
> ```
> cd ${CHROME_SRC}/third_party/WebKit/Source/platform/audio
> grep -rnw . -e 'ASSERT('
> ```
>
> BUG=707655
>
> Review-Url: https://codereview.chromium.org/2803073002
> Cr-Commit-Position: refs/heads/master@{#462904}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f90cae07269c724f98ca3c196ea3...TBR=rtoy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707655
Review-Url: https://codereview.chromium.org/2807593003
Cr-Commit-Position: refs/heads/master@{#462908}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4f0f6a6669b6bae15bb348d5a0b...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b4f0f6a6669b6bae15bb348d5a0bd39fb2ac5019
3 years, 8 months ago
(2017-04-07 17:30:53 UTC)
#6
Issue 2807593003: Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio
(Closed)
Created 3 years, 8 months ago by hongchan
Modified 3 years, 8 months ago
Reviewers: Raymond Toy
Base URL:
Comments: 0