Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp

Issue 2807593003: Revert of Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 24 matching lines...) Expand all
35 #include "platform/audio/VectorMath.h" 35 #include "platform/audio/VectorMath.h"
36 36
37 extern "C" { 37 extern "C" {
38 #include <libavcodec/avfft.h> 38 #include <libavcodec/avfft.h>
39 } 39 }
40 40
41 #include "platform/wtf/MathExtras.h" 41 #include "platform/wtf/MathExtras.h"
42 42
43 namespace blink { 43 namespace blink {
44 44
45 #if DCHECK_IS_ON()
45 // Max FFT size for FFMPEG. WebAudio currently only uses FFTs up to size 15 46 // Max FFT size for FFMPEG. WebAudio currently only uses FFTs up to size 15
46 // (2^15 points). 47 // (2^15 points).
47 const int kMaxFFTPow2Size = 16; 48 const int kMaxFFTPow2Size = 16;
49 #endif
48 50
49 // Normal constructor: allocates for a given fftSize. 51 // Normal constructor: allocates for a given fftSize.
50 FFTFrame::FFTFrame(unsigned fftSize) 52 FFTFrame::FFTFrame(unsigned fftSize)
51 : m_FFTSize(fftSize), 53 : m_FFTSize(fftSize),
52 m_log2FFTSize(static_cast<unsigned>(log2(fftSize))), 54 m_log2FFTSize(static_cast<unsigned>(log2(fftSize))),
53 m_realData(fftSize / 2), 55 m_realData(fftSize / 2),
54 m_imagData(fftSize / 2), 56 m_imagData(fftSize / 2),
55 m_forwardContext(nullptr), 57 m_forwardContext(nullptr),
56 m_inverseContext(nullptr), 58 m_inverseContext(nullptr),
57 m_complexData(fftSize) { 59 m_complexData(fftSize) {
58 // We only allow power of two. 60 // We only allow power of two.
59 DCHECK_EQ(1UL << m_log2FFTSize, m_FFTSize); 61 ASSERT(1UL << m_log2FFTSize == m_FFTSize);
60 62
61 m_forwardContext = contextForSize(fftSize, DFT_R2C); 63 m_forwardContext = contextForSize(fftSize, DFT_R2C);
62 m_inverseContext = contextForSize(fftSize, IDFT_C2R); 64 m_inverseContext = contextForSize(fftSize, IDFT_C2R);
63 } 65 }
64 66
65 // Creates a blank/empty frame (interpolate() must later be called). 67 // Creates a blank/empty frame (interpolate() must later be called).
66 FFTFrame::FFTFrame() 68 FFTFrame::FFTFrame()
67 : m_FFTSize(0), 69 : m_FFTSize(0),
68 m_log2FFTSize(0), 70 m_log2FFTSize(0),
69 m_forwardContext(nullptr), 71 m_forwardContext(nullptr),
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 return const_cast<float*>(m_complexData.data()); 150 return const_cast<float*>(m_complexData.data());
149 } 151 }
150 152
151 RDFTContext* FFTFrame::contextForSize(unsigned fftSize, int trans) { 153 RDFTContext* FFTFrame::contextForSize(unsigned fftSize, int trans) {
152 // FIXME: This is non-optimal. Ideally, we'd like to share the contexts for 154 // FIXME: This is non-optimal. Ideally, we'd like to share the contexts for
153 // FFTFrames of the same size. But FFmpeg's RDFT uses a scratch buffer 155 // FFTFrames of the same size. But FFmpeg's RDFT uses a scratch buffer
154 // inside the context and so they are not thread-safe. We could improve this 156 // inside the context and so they are not thread-safe. We could improve this
155 // by sharing the FFTFrames on a per-thread basis. 157 // by sharing the FFTFrames on a per-thread basis.
156 DCHECK(fftSize); 158 DCHECK(fftSize);
157 int pow2size = static_cast<int>(log2(fftSize)); 159 int pow2size = static_cast<int>(log2(fftSize));
158 DCHECK_LT(pow2size, kMaxFFTPow2Size); 160 ASSERT(pow2size < kMaxFFTPow2Size);
159 161
160 RDFTContext* context = av_rdft_init(pow2size, (RDFTransformType)trans); 162 RDFTContext* context = av_rdft_init(pow2size, (RDFTransformType)trans);
161 return context; 163 return context;
162 } 164 }
163 165
164 } // namespace blink 166 } // namespace blink
165 167
166 #endif // USE(WEBAUDIO_FFMPEG) 168 #endif // USE(WEBAUDIO_FFMPEG)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698