Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2807343002: Rename ScriptResource/WorkerScriptLoader::Script() to SourceText() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
index f608112ef44da15fcee181ee512af7e00b4c8631..d6a3a33bb5d7c43a9442ded08a9c82886187b9f1 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
@@ -210,7 +210,7 @@ void WorkerGlobalScope::importScripts(const Vector<String>& urls,
}
probe::scriptImported(&execution_context, script_loader->Identifier(),
- script_loader->Script());
+ script_loader->SourceText());
ErrorEvent* error_event = nullptr;
std::unique_ptr<Vector<char>> cached_meta_data(
@@ -218,13 +218,13 @@ void WorkerGlobalScope::importScripts(const Vector<String>& urls,
CachedMetadataHandler* handler(CreateWorkerScriptCachedMetadataHandler(
complete_url, cached_meta_data.get()));
GetThread()->GetWorkerReportingProxy().WillEvaluateImportedScript(
- script_loader->Script().length(),
+ script_loader->SourceText().length(),
script_loader->CachedMetadata()
? script_loader->CachedMetadata()->size()
: 0);
- script_controller_->Evaluate(
- ScriptSourceCode(script_loader->Script(), script_loader->ResponseURL()),
- &error_event, handler, v8_cache_options_);
+ script_controller_->Evaluate(ScriptSourceCode(script_loader->SourceText(),
+ script_loader->ResponseURL()),
+ &error_event, handler, v8_cache_options_);
if (error_event) {
script_controller_->RethrowExceptionFromImportedScript(error_event,
exception_state);

Powered by Google App Engine
This is Rietveld 408576698