[ObjC ARC] Clean up BVC from scoped_nsobject and weak_nsobject.

[ObjC ARC] Clean up BVC from scoped_nsobject and weak_nsobject.

This removes almost every scoped nsobject in BVC, with exception of
HeaderDefinition struct that will be removed in the next CL.

R=marq
BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2806483002
Cr-Commit-Position: refs/heads/master@{#463279}
Committed: https://chromium.googlesource.com/chromium/src/+/c9eee7b151df9f93a92b29100680ab80f1c06a3b

[marq (ping after 24h), 2017-04-06 14:54:55]

lgtm

https://codereview.chromium.org/2806483002/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2806483002/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:28: #import
"base/mac/scoped_nsobject.h"
Presumably this is still needed to access public scoped_nsobject properties or
variables of other objects?

[stkhapugin, 2017-04-06 14:56:51]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 14:57:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-04-06 14:58:29]

Thanks for a quick review!

https://codereview.chromium.org/2806483002/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2806483002/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:28: #import
"base/mac/scoped_nsobject.h"
On 2017/04/06 14:54:55, marq wrote:
> Presumably this is still needed to access public scoped_nsobject properties or
> variables of other objects?

No, it's for HeaderDefinition struct that I remove in a follow-up CL.

[commit-bot: I haz the power, 2017-04-06 15:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:17:32]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-04-10 14:01:09]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:01:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:04:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:04:04]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-04-10 15:00:03]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-04-10 15:00:03]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2806483002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-10 15:00:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:49:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491836403121710,
"parent_rev": "0466209552d01d70c5bb332ce94795f35cd4c9bf", "commit_rev":
"c9eee7b151df9f93a92b29100680ab80f1c06a3b"}

[commit-bot: I haz the power, 2017-04-10 15:50:30]

Description was changed from

==========
[ObjC ARC] Clean up BVC from scoped_nsobject and weak_nsobject.

This removes almost every scoped nsobject in BVC, with exception of
HeaderDefinition struct that will be removed in the next CL.

R=marq
BUG=None
TEST=None
==========

to

==========
[ObjC ARC] Clean up BVC from scoped_nsobject and weak_nsobject.

This removes almost every scoped nsobject in BVC, with exception of
HeaderDefinition struct that will be removed in the next CL.

R=marq
BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2806483002
Cr-Commit-Position: refs/heads/master@{#463279}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9eee7b151df9f93a92b29100680...
==========

[commit-bot: I haz the power, 2017-04-10 15:50:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c9eee7b151df9f93a92b29100680...