[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * This converts BVC to ARC, so please review with extra scrutiny.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2798903003
Cr-Commit-Position: refs/heads/master@{#463244}
Committed: https://chromium.googlesource.com/chromium/src/+/f58b10d0639545023e5f5bbc332e6cd0c0f3191e

[stkhapugin, 2017-04-05 15:05:13]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 15:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-04-05 15:22:16]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * This converts BVC to ARC, so please review with extra scrutiny.

BUG=624363
TEST=None
==========

[commit-bot: I haz the power, 2017-04-05 16:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 16:07:50]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-04-05 16:19:31]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org, sdefresne@chromium.org

[stkhapugin, 2017-04-05 16:19:32]

PTAL. Two reviewers because BVC.

[marq (ping after 24h), 2017-04-06 08:39:14]

LGTM with the understanding that there will be follow-up cleanup of
scoped_nsobjects inside (especially) the BVC implementation.

[sdefresne, 2017-04-06 10:56:26]

lgtm

https://codereview.chromium.org/2798903003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2798903003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:3201: case
PHAuthorizationStatusNotDetermined: {
Why the extra braces?

[stkhapugin, 2017-04-10 11:38:52]

THanks!

https://codereview.chromium.org/2798903003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2798903003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:3201: case
PHAuthorizationStatusNotDetermined: {
On 2017/04/06 10:56:25, sdefresne wrote:
> Why the extra braces?

Clang sometimes gets "confused" (compilation fails with clang internal error)
with blocks initialized inside of a switch statement's cases. This is a known
issue, I can find the clang bug for reference. The workaround is to put the
case's contents in a scope.

[stkhapugin, 2017-04-10 12:33:31]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-04-10 12:33:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2798903003/#ps20001
(title: "missing weaks from another patch")

[commit-bot: I haz the power, 2017-04-10 12:33:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:36:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491827611581250,
"parent_rev": "4feb2b85c555d8279df7477b7f418aa0a1556790", "commit_rev":
"f58b10d0639545023e5f5bbc332e6cd0c0f3191e"}

[commit-bot: I haz the power, 2017-04-10 13:37:09]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * This converts BVC to ARC, so please review with extra scrutiny.

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui:ui_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:
 * This converts BVC to ARC, so please review with extra scrutiny.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2798903003
Cr-Commit-Position: refs/heads/master@{#463244}
Committed:
https://chromium.googlesource.com/chromium/src/+/f58b10d0639545023e5f5bbc332e...
==========

[commit-bot: I haz the power, 2017-04-10 13:37:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f58b10d0639545023e5f5bbc332e...