Replaces HeaderDefinition struct with an object.

Replaces HeaderDefinition struct with an object.

Replaces HeaderDefinition struct used in BVC with an object that does
exactly the same thing. This allows for proper memory management for
its members, particularly the UIView* view that allows to get rid of
the last scoped_nsobjects.

R=marq
BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2802893003
Cr-Commit-Position: refs/heads/master@{#463601}
Committed: https://chromium.googlesource.com/chromium/src/+/952ecef527fb5c9395534a919fdc4051c1af2eb0

[marq (ping after 24h), 2017-04-06 14:58:16]

https://codereview.chromium.org/2802893003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2802893003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:2699: NSMutableArray* results =
[[NSMutableArray alloc] init];
NSMutableArray<HeaderDefinition*>* 

(also in the return value and the prototype.)

https://codereview.chromium.org/2802893003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:2736: return results;
[results copy]

[stkhapugin, 2017-04-10 15:15:48]

Thanks, PTAL

https://codereview.chromium.org/2802893003/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2802893003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:2699: NSMutableArray* results =
[[NSMutableArray alloc] init];
On 2017/04/06 14:58:16, marq wrote:
> NSMutableArray<HeaderDefinition*>* 
> 
> (also in the return value and the prototype.)

Done.

https://codereview.chromium.org/2802893003/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:2736: return results;
On 2017/04/06 14:58:16, marq wrote:
> [results copy]

Done.

[marq (ping after 24h), 2017-04-11 11:31:11]

lgtm

[stkhapugin, 2017-04-11 12:01:52]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-04-11 12:02:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 12:11:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491912112144580,
"parent_rev": "71dc84287165f0c3f9ab02e51dbedaffb6bf680f", "commit_rev":
"952ecef527fb5c9395534a919fdc4051c1af2eb0"}

[commit-bot: I haz the power, 2017-04-11 12:12:36]

Description was changed from

==========
Replaces HeaderDefinition struct with an object.

Replaces HeaderDefinition struct used in BVC with an object that does
exactly the same thing. This allows for proper memory management for
its members, particularly the UIView* view that allows to get rid of
the last scoped_nsobjects.

R=marq
BUG=None
TEST=None
==========

to

==========
Replaces HeaderDefinition struct with an object.

Replaces HeaderDefinition struct used in BVC with an object that does
exactly the same thing. This allows for proper memory management for
its members, particularly the UIView* view that allows to get rid of
the last scoped_nsobjects.

R=marq
BUG=None
TEST=None

Review-Url: https://codereview.chromium.org/2802893003
Cr-Commit-Position: refs/heads/master@{#463601}
Committed:
https://chromium.googlesource.com/chromium/src/+/952ecef527fb5c9395534a919fdc...
==========

[commit-bot: I haz the power, 2017-04-11 12:12:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/952ecef527fb5c9395534a919fdc...