Avoid duplicate functions/code in core/editing: MatchResultICU

Avoid duplicate functions/code in core/editing: MatchResultICU

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

There is a global MatchResult in css/SelectorChecker.h and if that one
is included anywhere in editing, then it will collide with a local
MatchResult used in iterators. Renaming the local one MatchResultICU
will both match the name of other symbols and avoid the collision.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2806433002
Cr-Commit-Position: refs/heads/master@{#462431}
Committed: https://chromium.googlesource.com/chromium/src/+/2bd991090f462a64efe0f6b26bf0ad35e19386b0

[Daniel Bratell, 2017-04-06 07:45:40]

bratell@opera.com changed reviewers:
+ yosin@chromium.org

[Daniel Bratell, 2017-04-06 07:45:40]

Please take a look.

[Daniel Bratell, 2017-04-06 09:14:15]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: MatchResultICU

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

There is a global MatchResult in css/SelectorChecker.h and if that one
is included anywhere in editing, then it will collide with a local
MatchResult used in iterators. Renaming the local one MatchResultICU
will both match the name of other symbols and avoid the collision.
==========

to

==========
Avoid duplicate functions/code in core/editing: MatchResultICU

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

There is a global MatchResult in css/SelectorChecker.h and if that one
is included anywhere in editing, then it will collide with a local
MatchResult used in iterators. Renaming the local one MatchResultICU
will both match the name of other symbols and avoid the collision.

BUG=708949
R=yosin@chromium.org
==========

[yosin_UTC9, 2017-04-06 09:57:38]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-04-06 09:57:38]

lgtm

[commit-bot: I haz the power, 2017-04-06 09:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:46:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491472658149980, "parent_rev":
"0cfc2fe30fabcd67f5b8b5fe158393ca194d8b45", "commit_rev":
"2bd991090f462a64efe0f6b26bf0ad35e19386b0"}

[commit-bot: I haz the power, 2017-04-06 11:47:35]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: MatchResultICU

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

There is a global MatchResult in css/SelectorChecker.h and if that one
is included anywhere in editing, then it will collide with a local
MatchResult used in iterators. Renaming the local one MatchResultICU
will both match the name of other symbols and avoid the collision.

BUG=708949
R=yosin@chromium.org
==========

to

==========
Avoid duplicate functions/code in core/editing: MatchResultICU

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

There is a global MatchResult in css/SelectorChecker.h and if that one
is included anywhere in editing, then it will collide with a local
MatchResult used in iterators. Renaming the local one MatchResultICU
will both match the name of other symbols and avoid the collision.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2806433002
Cr-Commit-Position: refs/heads/master@{#462431}
Committed:
https://chromium.googlesource.com/chromium/src/+/2bd991090f462a64efe0f6b26bf0...
==========

[commit-bot: I haz the power, 2017-04-06 11:47:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2bd991090f462a64efe0f6b26bf0...