Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp

Issue 2806433002: Avoid duplicate functions/code in core/editing: MatchResultICU (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp b/third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp
index e380d6cc18ccc559f6b47f03512bfe3ea914f70a..0636c4482ca89152c249e8a761bd8b4411cf4462 100644
--- a/third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp
+++ b/third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp
@@ -28,7 +28,7 @@ TEST(TextSearcherICUTest, FindSubstring) {
const String& text = makeUTF16("Long text with substring content.");
searcher.setText(text.characters16(), text.length());
- MatchResult result;
+ MatchResultICU result;
EXPECT_TRUE(searcher.nextMatchResult(result));
EXPECT_NE(0u, result.start);
@@ -49,7 +49,7 @@ TEST(TextSearcherICUTest, FindIgnoreCaseSubstring) {
const String& text = makeUTF16("Long text with SubStrinG content.");
searcher.setText(text.characters16(), text.length());
- MatchResult result;
+ MatchResultICU result;
EXPECT_TRUE(searcher.nextMatchResult(result));
EXPECT_NE(0u, result.start);
EXPECT_NE(0u, result.length);
@@ -72,20 +72,20 @@ TEST(TextSearcherICUTest, FindSubstringWithOffset) {
makeUTF16("Long text with substring content. Second substring");
searcher.setText(text.characters16(), text.length());
- MatchResult firstResult;
+ MatchResultICU firstResult;
EXPECT_TRUE(searcher.nextMatchResult(firstResult));
EXPECT_NE(0u, firstResult.start);
EXPECT_NE(0u, firstResult.length);
- MatchResult secondResult;
+ MatchResultICU secondResult;
EXPECT_TRUE(searcher.nextMatchResult(secondResult));
EXPECT_NE(0u, secondResult.start);
EXPECT_NE(0u, secondResult.length);
searcher.setOffset(firstResult.start + firstResult.length);
- MatchResult offsetResult;
+ MatchResultICU offsetResult;
EXPECT_TRUE(searcher.nextMatchResult(offsetResult));
EXPECT_EQ(offsetResult.start, secondResult.start);
EXPECT_EQ(offsetResult.length, secondResult.length);
« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698