third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp - Issue 2806433002: Avoid duplicate functions/code in core/editing: MatchResultICU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp

Issue 2806433002: Avoid duplicate functions/code in core/editing: MatchResultICU (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.h ('k') | third_party/WebKit/Source/core/editing/iterators/TextSearcherICUTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp b/third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp

index 42687bcea8174fa01297aaee573d072d30ce65d9..a961fc069303f4022436d1381ccebc44639dbd8e 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/TextSearcherICU.cpp

@@ -129,7 +129,7 @@ void TextSearcherICU::setOffset(size_t offset) {

DCHECK_EQ(status, U_ZERO_ERROR);

}

-bool TextSearcherICU::nextMatchResult(MatchResult& result) {

+bool TextSearcherICU::nextMatchResult(MatchResultICU& result) {

UErrorCode status = U_ZERO_ERROR;

const int matchStart = usearch_next(m_searcher, &status);

DCHECK_EQ(status, U_ZERO_ERROR);