Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2805843003: Network traffic annotation added to components/ unittests. (Closed)

Created:
3 years, 8 months ago by Ramin Halavati
Modified:
3 years, 8 months ago
CC:
battre, bnc+watch_chromium.org, chromium-reviews, eroman, mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to components/ unittests. Test Network traffic annotation tag is added to network requests of uniitests in components/. BUG=656607 Review-Url: https://codereview.chromium.org/2805843003 Cr-Commit-Position: refs/heads/master@{#463240} Committed: https://chromium.googlesource.com/chromium/src/+/af4f14c5b703f34856ac830bba4654195f3c0ceb

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Ramin Halavati
Unittests do not require annotations, but as we will activate presubmit checking in near future ...
3 years, 8 months ago (2017-04-07 14:05:05 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-10 12:30:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805843003/1
3 years, 8 months ago (2017-04-10 12:33:11 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 13:16:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af4f14c5b703f34856ac830bba46...

Powered by Google App Engine
This is Rietveld 408576698