components/policy/core/common/cloud/policy_header_service_unittest.cc - Issue 2805843003: Network traffic annotation added to components/ unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/policy_header_service_unittest.cc

Issue 2805843003: Network traffic annotation added to components/ unittests. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/policy_header_io_helper_unittest.cc ('k') | components/previews/core/previews_io_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/policy_header_service_unittest.cc

diff --git a/components/policy/core/common/cloud/policy_header_service_unittest.cc b/components/policy/core/common/cloud/policy_header_service_unittest.cc

index 2a85b45f12219bb88d72f78fc46f7630f8229fcc..a4c0073257864a48d8830b57be59d92761d9a80d 100644

--- a/components/policy/core/common/cloud/policy_header_service_unittest.cc

+++ b/components/policy/core/common/cloud/policy_header_service_unittest.cc

@@ -16,6 +16,7 @@

#include "components/policy/core/common/cloud/mock_cloud_policy_store.h"

#include "components/policy/core/common/cloud/policy_header_io_helper.h"

#include "net/http/http_request_headers.h"

+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_test_util.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -111,7 +112,8 @@ TEST_F(PolicyHeaderServiceTest, TestWithAndWithoutPolicyHeader) {

net::TestURLRequestContext context;

std::unique_ptr<net::URLRequest> request(

- context.CreateRequest(GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL));

+ context.CreateRequest(GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL,

+ TRAFFIC_ANNOTATION_FOR_TESTS));

helper_->AddPolicyHeaders(request->url(), request.get());

ValidateHeader(request->extra_request_headers(), expected_dmtoken,

expected_policy_token);

@@ -121,7 +123,8 @@ TEST_F(PolicyHeaderServiceTest, TestWithAndWithoutPolicyHeader) {

task_runner_->RunUntilIdle();

std::unique_ptr<net::URLRequest> request2(

- context.CreateRequest(GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL));

+ context.CreateRequest(GURL(kDMServerURL), net::DEFAULT_PRIORITY, NULL,

+ TRAFFIC_ANNOTATION_FOR_TESTS));

helper_->AddPolicyHeaders(request2->url(), request2.get());

ValidateHeader(request2->extra_request_headers(), "", "");

}