components/data_use_measurement/core/data_use_network_delegate_unittest.cc - Issue 2805843003: Network traffic annotation added to components/ unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_use_measurement/core/data_use_network_delegate_unittest.cc

Issue 2805843003: Network traffic annotation added to components/ unittests. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_use_measurement/core/data_use_measurement_unittest.cc ('k') | components/net_log/net_log_file_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_use_measurement/core/data_use_network_delegate_unittest.cc

diff --git a/components/data_use_measurement/core/data_use_network_delegate_unittest.cc b/components/data_use_measurement/core/data_use_network_delegate_unittest.cc

index b5f3fd9aa0e9884ffc65a88aeed16a9991d6ba32..468025ade5b2de47b6ea44e2cfc478bd25c9b8c7 100644

--- a/components/data_use_measurement/core/data_use_network_delegate_unittest.cc

+++ b/components/data_use_measurement/core/data_use_network_delegate_unittest.cc

@@ -12,6 +12,7 @@

#include "components/data_use_measurement/core/url_request_classifier.h"

#include "components/metrics/data_use_tracker.h"

#include "net/socket/socket_test_util.h"

+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_test_util.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -97,8 +98,9 @@ std::unique_ptr<net::URLRequest> RequestURL(

socket_factory->AddSocketDataProvider(&response_socket_data_provider);

net::TestDelegate test_delegate;

test_delegate.set_quit_on_complete(true);

- std::unique_ptr<net::URLRequest> request(context->CreateRequest(

- GURL("http://example.com"), net::DEFAULT_PRIORITY, &test_delegate));

+ std::unique_ptr<net::URLRequest> request(

+ context->CreateRequest(GURL("http://example.com"), net::DEFAULT_PRIORITY,

+ &test_delegate, TRAFFIC_ANNOTATION_FOR_TESTS));

if (from_user) {

TestURLRequestClassifier::MarkAsUserRequest(request.get());