Boolean properties for Accessibility Object Model Phase 1

Boolean properties for Accessibility Object Model Phase 1

BUG=680345
Review-Url: https://codereview.chromium.org/2805493002
Cr-Commit-Position: refs/heads/master@{#472634}
Committed: https://chromium.googlesource.com/chromium/src/+/596baeaaa2a5632f606a226ebdf898272cd4284d

[dmazzoni, 2017-04-05 19:48:03]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-04-05 19:48:28]

Description was changed from

==========
Boolean attributes for Accessibility Object Model Phase 1

BUG=680345
==========

to

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345
==========

[commit-bot: I haz the power, 2017-04-05 19:48:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-04-05 19:48:42]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org, esprehn@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:40:05]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-04-07 00:11:23]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org

[esprehn, 2017-04-07 00:11:24]

haraken@ I'm curious so these properties are nullable which means getting them
can return null, but why does setting null turn into false? Is that what web idl
really specs?

I'd expect foo.property = null to turn it back into null instead, but I guess
web idl says something else? It seems the generated setter here has no way to
reassign null.

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/AccessibleNode.cpp (right):

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/AccessibleNode.cpp:126: if
(attrValue.isNull())
equalIgnoringASCIICase handles nulls, so you can do:

isNull = attrValue.isNull();
return equalIgnoringASCIICase(attrValue, "true");

[haraken, 2017-04-07 02:33:51]

haraken@chromium.org changed reviewers:
+ bashi@chromium.org

[haraken, 2017-04-07 02:33:51]

+bashi for the IDL value conversion question.

[bashi, 2017-04-07 03:52:45]

Seems like a historical bug in the code generator. We should use Nullable<bool>
but we use bool for setters. The binding layer uses
NativeValueTraits<IDLBoolean>::nativeValue() and it returns false when null is
passed.

Looks like we need to update all attribute setters of boolean? to fix the bug.

[aboxhall, 2017-04-07 05:22:35]

I don't follow Elliott's comments so I'm just assuming you do and that hoping my
comments aren't nonsensical in context.

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/AccessibleNode.h (right):

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/AccessibleNode.h:71: // Returns the alue of
the given boolean property if the
typo "alue"

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXObject.cpp:392: bool
AXObject::getAOMPropertyOrARIAAttribute(AOMBooleanProperty property,
Ok, now I see what you were talking about.

This is incredibly confusing since the form of getAOMPropertyOrARIAAttribute()
directly above returns the value, and this returns a boolean making it _look
like_ it's returning the value, but actually it's effectively returning the
result of hasAOMPropertyOrARIAAttribute. This seems like a hole waiting for
someone to fall in it :)

What about:
- making hasAOMPropertyOrARIAAttribute() work like this currently works (I see
it's not called anywhere currently?) - or maybe call it something like
canGetAOMPropertyOrARIAAttribute() (like "try to get this and let me know if you
got it")
- making a convenience version of hasAOMPropertyOrARIAAttribute() which doesn't
take a `result` reference but delegates to the one which does
- making getAOMPropertyOrARIAAttribute() work like AccessibleNode::getProperty()
(or just getting rid of it altogether and insisting on using the isTrue/isFalse
method)

i.e.
  bool getAOMPropertyOrARIAAttribute(AOMBooleanProperty, bool& isNull) const; 
// returns false if isNull gets set to true
  bool hasAOMPropertyOrARIAAttribute(AOMBooleanProperty, bool& value) const;
  bool hasAOMPropertyOrARIAAttribute(AOMBooleanProperty) const;  // delegates to
above

then the callsites look like

if (hasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kModal, modal))
  return modal;

or

if (canGetAOMPropertyOrARIAAttribute(AOMBooleanProperty::kDisabled, disabled)) {
  if (disabled)
    return this;
  return nullptr;
}

There's still potentially a more minor footgun in that you have to know to check
isNull when calling getAOMPropertyOrARIAAttribute for a boolean attribute, but
this is consistent with the API on AccessibleNode.

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXObject.cpp:394: Node* node =
this->getNode();
Would it help to make a convenience protected/private method
AXObject::GetElement which returns nullptr if node is null or not an element,
and an Element pointer otherwise?

[dmazzoni, 2017-04-07 15:38:37]

I don't actually see boolean? in any other web idl files:

https://cs.chromium.org/search/?q=file:idl+file:webkit+boolean%5C?+package:%5...

Of the two results, one is commented out and the other is in a test.

Does that mean it's an easy change? @bashi, should I wait for you to make
this change to the code generator?

On Thu, Apr 6, 2017 at 8:52 PM <bashi@chromium.org> wrote:

> Seems like a historical bug in the code generator. We should use
> Nullable<bool>
> but we use bool for setters. The binding layer uses
> NativeValueTraits<IDLBoolean>::nativeValue() and it returns false when
> null is
> passed.
>
> Looks like we need to update all attribute setters of boolean? to fix the
> bug.
>
> https://codereview.chromium.org/2805493002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-04-07 15:38:37]

I don't actually see boolean? in any other web idl files:

https://cs.chromium.org/search/?q=file:idl+file:webkit+boolean%5C?+package:%5...

Of the two results, one is commented out and the other is in a test.

Does that mean it's an easy change? @bashi, should I wait for you to make
this change to the code generator?

On Thu, Apr 6, 2017 at 8:52 PM <bashi@chromium.org> wrote:

> Seems like a historical bug in the code generator. We should use
> Nullable<bool>
> but we use bool for setters. The binding layer uses
> NativeValueTraits<IDLBoolean>::nativeValue() and it returns false when
> null is
> passed.
>
> Looks like we need to update all attribute setters of boolean? to fix the
> bug.
>
> https://codereview.chromium.org/2805493002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bashi, 2017-04-10 00:38:10]

On 2017/04/07 15:38:37, dmazzoni wrote:
> I don't actually see boolean? in any other web idl files:
> 
>
https://cs.chromium.org/search/?q=file:idl+file:webkit+boolean%5C?+package:%5...
> 
> Of the two results, one is commented out and the other is in a test.
> 
> Does that mean it's an easy change? @bashi, should I wait for you to make
> this change to the code generator?
> 
> On Thu, Apr 6, 2017 at 8:52 PM <mailto:bashi@chromium.org> wrote:
> 
> > Seems like a historical bug in the code generator. We should use
> > Nullable<bool>
> > but we use bool for setters. The binding layer uses
> > NativeValueTraits<IDLBoolean>::nativeValue() and it returns false when
> > null is
> > passed.

Oh, yes. But I noticed that we use the same code path for other nullable (e.g.
long?) and some interfaces use it (e.g. Animation). Probably an easy workaround
is passing 'is_null' argument to setters. I'll try to do that.

> >
> > Looks like we need to update all attribute setters of boolean? to fix the
> > bug.
> >
> > https://codereview.chromium.org/2805493002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[bashi, 2017-04-10 03:14:10]

Workaround is landed.
https://codereview.chromium.org/2809543002

[dmazzoni, 2017-04-11 05:51:55]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 05:52:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 06:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 06:02:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[esprehn, 2017-04-21 03:17:46]

Is this ready for another review?

[dmazzoni, 2017-04-21 06:13:12]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 06:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 06:25:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 06:25:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-04-21 07:11:36]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2017-04-21 07:11:38]

Ready for another look

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/AccessibleNode.cpp (right):

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/AccessibleNode.cpp:126: if
(attrValue.isNull())
On 2017/04/07 00:11:24, esprehn wrote:
> equalIgnoringASCIICase handles nulls, so you can do:
> 
> isNull = attrValue.isNull();
> return equalIgnoringASCIICase(attrValue, "true");

Done.

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/AccessibleNode.h (right):

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/AccessibleNode.h:71: // Returns the alue of
the given boolean property if the
On 2017/04/07 05:22:35, aboxhall wrote:
> typo "alue"

Done.

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXObject.cpp:392: bool
AXObject::getAOMPropertyOrARIAAttribute(AOMBooleanProperty property,
On 2017/04/07 05:22:35, aboxhall wrote:
> Ok, now I see what you were talking about.
> 
> This is incredibly confusing since the form of getAOMPropertyOrARIAAttribute()
> directly above returns the value, and this returns a boolean making it _look
> like_ it's returning the value, but actually it's effectively returning the
> result of hasAOMPropertyOrARIAAttribute. This seems like a hole waiting for
> someone to fall in it :)
> 
> What about:
> - making hasAOMPropertyOrARIAAttribute() work like this currently works (I see
> it's not called anywhere currently?) - or maybe call it something like
> canGetAOMPropertyOrARIAAttribute() (like "try to get this and let me know if
you
> got it")
> - making a convenience version of hasAOMPropertyOrARIAAttribute() which
doesn't
> take a `result` reference but delegates to the one which does
> - making getAOMPropertyOrARIAAttribute() work like
AccessibleNode::getProperty()
> (or just getting rid of it altogether and insisting on using the
isTrue/isFalse
> method)
> 
> i.e.
>   bool getAOMPropertyOrARIAAttribute(AOMBooleanProperty, bool& isNull) const; 
> // returns false if isNull gets set to true
>   bool hasAOMPropertyOrARIAAttribute(AOMBooleanProperty, bool& value) const;
>   bool hasAOMPropertyOrARIAAttribute(AOMBooleanProperty) const;  // delegates
to
> above
> 
> then the callsites look like
> 
> if (hasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kModal, modal))
>   return modal;
> 
> or
> 
> if (canGetAOMPropertyOrARIAAttribute(AOMBooleanProperty::kDisabled, disabled))
{
>   if (disabled)
>     return this;
>   return nullptr;
> }
> 
> There's still potentially a more minor footgun in that you have to know to
check
> isNull when calling getAOMPropertyOrARIAAttribute for a boolean attribute, but
> this is consistent with the API on AccessibleNode.

Thanks for the discussion.

I went with this form:

bool hasAOMPropertyOrARIAAttribute(AOMBooleanProperty, bool& value) const;

I don't think we need the version that just returns whether there's a value or
not, delegating to this
form, because it encourages calling it twice, which is unnecessarily expensive.

https://codereview.chromium.org/2805493002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXObject.cpp:394: Node* node =
this->getNode();
On 2017/04/07 05:22:35, aboxhall wrote:
> Would it help to make a convenience protected/private method
> AXObject::GetElement which returns nullptr if node is null or not an element,
> and an Element pointer otherwise?

Good idea. Used it throughout the file.

https://codereview.chromium.org/2805493002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html
(right):

https://codereview.chromium.org/2805493002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html:28:
node.accessibleNode.atomic = null;
@aboxhall, what should happen here?

The spec says that the last value written should win, but that seems really
unclear in the case where you set the value to null, for a boolean type.

[commit-bot: I haz the power, 2017-04-21 07:11:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 08:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 08:58:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-08 05:31:14]

Updated based on the latest spec change.

https://codereview.chromium.org/2805493002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html
(right):

https://codereview.chromium.org/2805493002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html:28:
node.accessibleNode.atomic = null;
On 2017/04/21 07:11:37, dmazzoni wrote:
> @aboxhall, what should happen here?
> 
> The spec says that the last value written should win, but that seems really
> unclear in the case where you set the value to null, for a boolean type.

Resolved now, with new tests, based on the latest spec.

[dmazzoni, 2017-05-08 05:32:30]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 05:32:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 06:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 06:21:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aboxhall, 2017-05-10 06:37:10]

lgtm

[dmazzoni, 2017-05-10 06:58:39]

dmazzoni@chromium.org changed reviewers:
+ mkwst@chromium.org
- bashi@chromium.org, esprehn@chromium.org, haraken@chromium.org

[dmazzoni, 2017-05-10 06:58:40]

+mkwst for owners review

[Mike West, 2017-05-15 07:49:31]

LGTM (sorry I missed this! If you wait more than a day, please ping me. :) )

[dmazzoni, 2017-05-15 21:57:49]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-15 21:57:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2805493002/#ps170001
(title: "Fix typo in merged comment")

[commit-bot: I haz the power, 2017-05-15 21:58:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:23:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:23:41]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dmazzoni, 2017-05-16 04:39:07]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-16 04:39:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2805493002/#ps190001
(title: "Fix test compile error on Android")

[commit-bot: I haz the power, 2017-05-16 04:39:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 06:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 06:10:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-16 18:15:23]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-05-16 18:16:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 20:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 20:45:34]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-16 21:20:29]

Description was changed from

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345
==========

to

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345
NOTRY=true
==========

[dmazzoni, 2017-05-16 21:20:46]

Only failure is a known flake, adding notry

[dmazzoni, 2017-05-17 04:32:15]

Description was changed from

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345
NOTRY=true
==========

to

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345
==========

[dmazzoni, 2017-05-17 04:32:21]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:33:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:43:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-17 05:54:01]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-17 05:54:01]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2805493002/#ps210001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-17 05:55:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-05-17 06:19:41]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2017-05-17 15:25:09]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-17 15:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2805493002/#ps230001
(title: "Back to previous patchset, ready to land")

[commit-bot: I haz the power, 2017-05-17 15:25:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:00:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-17 23:49:57]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:51:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:28:18]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1495064997392260,
"parent_rev": "257ccdb4fa9b6a50d24f0f736402874dab49a5d2", "commit_rev":
"a2229f9423c129ab56d13637d5d2ee4809226eb5"}

[commit-bot: I haz the power, 2017-05-18 03:28:34]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1495064997392260,
"parent_rev": "9a50e07bda300db2b09f4caf8bb52943bee15b4d", "commit_rev":
"596baeaaa2a5632f606a226ebdf898272cd4284d"}

[commit-bot: I haz the power, 2017-05-18 03:28:44]

Description was changed from

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345
==========

to

==========
Boolean properties for Accessibility Object Model Phase 1

BUG=680345

Review-Url: https://codereview.chromium.org/2805493002
Cr-Commit-Position: refs/heads/master@{#472634}
Committed:
https://chromium.googlesource.com/chromium/src/+/596baeaaa2a5632f606a226ebdf8...
==========

[commit-bot: I haz the power, 2017-05-18 03:28:46]

Committed patchset #13 (id:230001) as
https://chromium.googlesource.com/chromium/src/+/596baeaaa2a5632f606a226ebdf8...