third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 2805493002: Boolean properties for Accessibility Object Model Phase 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 2805493002: Boolean properties for Accessibility Object Model Phase 1 (Closed)

Patch Set: Back to previous patchset, ready to land Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 1278b64ec79be70410791fb5960d36ef69e539c4..fb07f28b4abfafacda7581fc879b9c700d00c7a9 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -30,6 +30,7 @@

#include "core/HTMLNames.h"

#include "core/InputTypeNames.h"

+#include "core/dom/AccessibleNode.h"

#include "core/dom/Document.h"

#include "core/dom/TaskRunnerHelper.h"

#include "core/editing/EditingUtilities.h"

@@ -1099,8 +1100,10 @@ bool IsNodeAriaVisible(Node* node) {

if (!node->IsElementNode())

return false;

- return EqualIgnoringASCIICase(ToElement(node)->getAttribute(aria_hiddenAttr),

- "false");

+ bool is_null = true;

+ bool hidden = AccessibleNode::GetPropertyOrARIAAttribute(

+ ToElement(node), AOMBooleanProperty::kHidden, is_null);

+ return !is_null && !hidden;

}

void AXObjectCacheImpl::PostPlatformNotification(AXObjectImpl* obj,