Remove unnecessary promo_type_ field from notification_promo.h/.cc.

Remove unnecessary promo_type_ field from notification_promo.h/.cc.

Removes the promo_type_ field from notification_promo.h/.cc
and uses of it. It is unnecessary as the only promo type in use is the
MOBILE_NTP_WHATS_NEW_PROMO.

BUG=608525
Review-Url: https://codereview.chromium.org/2805443007
Cr-Commit-Position: refs/heads/master@{#463344}
Committed: https://chromium.googlesource.com/chromium/src/+/1f5bbbc2bdb5af6fa4d6940dbefb9538620d8d1c

[gchatz, 2017-04-07 22:48:36]

gchatz@chromium.org changed reviewers:
+ justincohen@chromium.org, rohitrao@chromium.org

[rohitrao (ping after 24h), 2017-04-10 12:49:17]

LGTM

Could you please update the CL description to add a short explanation of why
this is no longer necessary?  (It looks like the only supported promo type is
MOBILE_NTP_PROMO?)

[justincohen, 2017-04-10 15:32:13]

LGTM with q

https://codereview.chromium.org/2805443007/diff/1/ios/chrome/browser/notifica...
File ios/chrome/browser/notification_promo.cc (left):

https://codereview.chromium.org/2805443007/diff/1/ios/chrome/browser/notifica...
ios/chrome/browser/notification_promo.cc:159: promo_type_ = promo_type;
Was this data ever stored in prefs?

[gchatz, 2017-04-10 18:32:06]

Description was changed from

==========
Remove unnecessary promo_type_ field from notification_promo.h/.cc.

Removes the unecessary promo_type_ field from notification_promo.h/.cc
and uses of it.

BUG=608525
==========

to

==========
Remove unnecessary promo_type_ field from notification_promo.h/.cc.

Removes the promo_type_ field from notification_promo.h/.cc
and uses of it. It is unnecessary as the only promo type in use is the
MOBILE_NTP_WHATS_NEW_PROMO.

BUG=608525
==========

[gchatz, 2017-04-10 18:32:24]

Updated description.

https://codereview.chromium.org/2805443007/diff/1/ios/chrome/browser/notifica...
File ios/chrome/browser/notification_promo.cc (left):

https://codereview.chromium.org/2805443007/diff/1/ios/chrome/browser/notifica...
ios/chrome/browser/notification_promo.cc:159: promo_type_ = promo_type;
On 2017/04/10 15:32:13, justincohen wrote:
> Was this data ever stored in prefs?

It was in the old pref structure, but not since we supported having multiple
promos. If a user upgrades to this version the old pref structure, it would be
blown away and resaved in the new structure.

[gchatz, 2017-04-10 18:32:39]

The CQ bit was checked by gchatz@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:33:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:56:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491849159241860, "parent_rev":
"be2222edd8ec874f2b200202f7450f34d1f8f017", "commit_rev":
"1f5bbbc2bdb5af6fa4d6940dbefb9538620d8d1c"}

[commit-bot: I haz the power, 2017-04-10 18:57:45]

Description was changed from

==========
Remove unnecessary promo_type_ field from notification_promo.h/.cc.

Removes the promo_type_ field from notification_promo.h/.cc
and uses of it. It is unnecessary as the only promo type in use is the
MOBILE_NTP_WHATS_NEW_PROMO.

BUG=608525
==========

to

==========
Remove unnecessary promo_type_ field from notification_promo.h/.cc.

Removes the promo_type_ field from notification_promo.h/.cc
and uses of it. It is unnecessary as the only promo type in use is the
MOBILE_NTP_WHATS_NEW_PROMO.

BUG=608525

Review-Url: https://codereview.chromium.org/2805443007
Cr-Commit-Position: refs/heads/master@{#463344}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f5bbbc2bdb5af6fa4d6940dbefb...
==========

[commit-bot: I haz the power, 2017-04-10 18:57:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f5bbbc2bdb5af6fa4d6940dbefb...