Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: ios/chrome/browser/notification_promo.h

Issue 2805443007: Remove unnecessary promo_type_ field from notification_promo.h/.cc. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/notification_promo.cc » ('j') | ios/chrome/browser/notification_promo.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/notification_promo.h
diff --git a/ios/chrome/browser/notification_promo.h b/ios/chrome/browser/notification_promo.h
index 0b70ed7702f0e630c3042ec9ed524aa986813e57..dda497c646c9bd08668d152425ec3f8f046f115d 100644
--- a/ios/chrome/browser/notification_promo.h
+++ b/ios/chrome/browser/notification_promo.h
@@ -27,15 +27,6 @@ namespace ios {
// or prefs.
class NotificationPromo {
public:
- // TODO(crbug.com/608525): Remove when this code is refactored.
- enum PromoType {
- NO_PROMO,
- NTP_NOTIFICATION_PROMO,
- NTP_BUBBLE_PROMO,
- MOBILE_NTP_SYNC_PROMO,
- MOBILE_NTP_WHATS_NEW_PROMO,
- };
-
explicit NotificationPromo(PrefService* local_state);
~NotificationPromo();
@@ -43,8 +34,8 @@ class NotificationPromo {
void InitFromVariations();
// Initialize from json/prefs.
- void InitFromJson(const base::DictionaryValue& json, PromoType promo_type);
- void InitFromPrefs(PromoType promo_type);
+ void InitFromJson(const base::DictionaryValue& json);
+ void InitFromPrefs();
// Can this promo be shown?
bool CanShow() const;
@@ -60,7 +51,6 @@ class NotificationPromo {
void HandleViewed();
const std::string& promo_text() const { return promo_text_; }
- PromoType promo_type() const { return promo_type_; }
const base::DictionaryValue* promo_payload() const {
return promo_payload_.get();
}
@@ -100,7 +90,6 @@ class NotificationPromo {
PrefService* local_state_;
- PromoType promo_type_;
std::string promo_text_;
std::unique_ptr<const base::DictionaryValue> promo_payload_;
« no previous file with comments | « no previous file | ios/chrome/browser/notification_promo.cc » ('j') | ios/chrome/browser/notification_promo.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698