Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm

Issue 2805443007: Remove unnecessary promo_type_ field from notification_promo.h/.cc. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
diff --git a/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm b/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
index e47479fa9c9c7b34ade4a3a8679ae0ba30ced885..c30a2fac5f14a58c11505a1969c09bbef9c8120c 100644
--- a/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
+++ b/ios/chrome/browser/ui/ntp/notification_promo_whats_new.mm
@@ -95,8 +95,7 @@ bool NotificationPromoWhatsNew::Init() {
}
}
- notification_promo_.InitFromPrefs(
- ios::NotificationPromo::MOBILE_NTP_WHATS_NEW_PROMO);
+ notification_promo_.InitFromPrefs();
return InitFromNotificationPromo();
}
@@ -105,8 +104,7 @@ bool NotificationPromoWhatsNew::ClearAndInitFromJson(
// This clears away old promos.
notification_promo_.MigrateUserPrefs(local_state_);
- notification_promo_.InitFromJson(
- json, ios::NotificationPromo::MOBILE_NTP_WHATS_NEW_PROMO);
+ notification_promo_.InitFromJson(json);
return InitFromNotificationPromo();
}
@@ -276,7 +274,6 @@ void NotificationPromoWhatsNew::InjectFakePromo(const std::string& promo_id,
base::JSONReader::Read(promo_json_filled_in));
base::DictionaryValue* dict = NULL;
if (value->GetAsDictionary(&dict)) {
- notification_promo_.InitFromJson(
- *dict, ios::NotificationPromo::MOBILE_NTP_WHATS_NEW_PROMO);
+ notification_promo_.InitFromJson(*dict);
}
}
« ios/chrome/browser/notification_promo.cc ('K') | « ios/chrome/browser/notification_promo_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698