TetherNotificationPresenter: Connect to a network when the 'Connect' button is pressed.

TetherNotificationPresenter: Connect to a network when the 'Connect' button is pressed.

BUG=672263
Review-Url: https://codereview.chromium.org/2805393002
Cr-Commit-Position: refs/heads/master@{#463456}
Committed: https://chromium.googlesource.com/chromium/src/+/73049b49ecf58eab0a0f19e2501a1d4d31e61250

[Ryan Hansberry, 2017-04-08 00:21:20]

Description was changed from

==========
TetherNotificationPresenter: Connect to a network when the 'Connect' button is
pressed.

BUG=672263
==========

to

==========
TetherNotificationPresenter: Connect to a network when the 'Connect' button is
pressed.

BUG=672263
==========

[Ryan Hansberry, 2017-04-08 00:21:20]

hansberry@chromium.org changed reviewers:
+ khorimoto@chromium.org, stevenjb@chromium.org

[Kyle Horimoto, 2017-04-08 00:45:22]

lgtm

[stevenjb, 2017-04-10 19:55:51]

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
File chrome/browser/chromeos/net/tether_notification_presenter.cc (right):

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
chrome/browser/chromeos/net/tether_notification_presenter.cc:66:
NetworkConnect::Get()) {}
We shouldn't provide this extra constructor. We should pass these explicitly
wherever TetherNotificationPresenter is constructed to make it easier to check
the lifetime guarantees.

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
File chrome/browser/chromeos/net/tether_notification_presenter.h (right):

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
chrome/browser/chromeos/net/tether_notification_presenter.h:54: NetworkConnect*
network_connect);
Can you add a comment that |message_center| and |network_connect| must both be
guaranteed to outlive the instance?

[Ryan Hansberry, 2017-04-10 22:28:55]

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
File chrome/browser/chromeos/net/tether_notification_presenter.cc (right):

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
chrome/browser/chromeos/net/tether_notification_presenter.cc:66:
NetworkConnect::Get()) {}
On 2017/04/10 19:55:51, stevenjb wrote:
> We shouldn't provide this extra constructor. We should pass these explicitly
> wherever TetherNotificationPresenter is constructed to make it easier to check
> the lifetime guarantees.

Done.

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
File chrome/browser/chromeos/net/tether_notification_presenter.h (right):

https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net...
chrome/browser/chromeos/net/tether_notification_presenter.h:54: NetworkConnect*
network_connect);
On 2017/04/10 19:55:51, stevenjb wrote:
> Can you add a comment that |message_center| and |network_connect| must both be
> guaranteed to outlive the instance?

Done.

[stevenjb, 2017-04-10 22:55:43]

lgtm

[Ryan Hansberry, 2017-04-10 23:05:47]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2017-04-10 23:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2805393002/#ps20001
(title: "Remove extra constructor.")

[commit-bot: I haz the power, 2017-04-10 23:06:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:59:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491865547503240,
"parent_rev": "399458cbfa1d8458842e9119e6ad063716c7e66e", "commit_rev":
"73049b49ecf58eab0a0f19e2501a1d4d31e61250"}

[commit-bot: I haz the power, 2017-04-11 00:00:00]

Description was changed from

==========
TetherNotificationPresenter: Connect to a network when the 'Connect' button is
pressed.

BUG=672263
==========

to

==========
TetherNotificationPresenter: Connect to a network when the 'Connect' button is
pressed.

BUG=672263

Review-Url: https://codereview.chromium.org/2805393002
Cr-Commit-Position: refs/heads/master@{#463456}
Committed:
https://chromium.googlesource.com/chromium/src/+/73049b49ecf58eab0a0f19e2501a...
==========

[commit-bot: I haz the power, 2017-04-11 00:00:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73049b49ecf58eab0a0f19e2501a...