Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2805393002: TetherNotificationPresenter: Connect to a network when the 'Connect' button is pressed. (Closed)

Created:
3 years, 8 months ago by Ryan Hansberry
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, Kyle Horimoto
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

TetherNotificationPresenter: Connect to a network when the 'Connect' button is pressed. BUG=672263 Review-Url: https://codereview.chromium.org/2805393002 Cr-Commit-Position: refs/heads/master@{#463456} Committed: https://chromium.googlesource.com/chromium/src/+/73049b49ecf58eab0a0f19e2501a1d4d31e61250

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove extra constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -19 lines) Patch
M chrome/browser/chromeos/net/tether_notification_presenter.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/net/tether_notification_presenter.cc View 1 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc View 3 chunks +46 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ryan Hansberry
3 years, 8 months ago (2017-04-08 00:21:26 UTC) #3
Kyle Horimoto
lgtm
3 years, 8 months ago (2017-04-08 00:45:22 UTC) #4
stevenjb
https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net/tether_notification_presenter.cc File chrome/browser/chromeos/net/tether_notification_presenter.cc (right): https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net/tether_notification_presenter.cc#newcode66 chrome/browser/chromeos/net/tether_notification_presenter.cc:66: NetworkConnect::Get()) {} We shouldn't provide this extra constructor. We ...
3 years, 8 months ago (2017-04-10 19:55:51 UTC) #5
Ryan Hansberry
https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net/tether_notification_presenter.cc File chrome/browser/chromeos/net/tether_notification_presenter.cc (right): https://codereview.chromium.org/2805393002/diff/1/chrome/browser/chromeos/net/tether_notification_presenter.cc#newcode66 chrome/browser/chromeos/net/tether_notification_presenter.cc:66: NetworkConnect::Get()) {} On 2017/04/10 19:55:51, stevenjb wrote: > We ...
3 years, 8 months ago (2017-04-10 22:28:55 UTC) #6
stevenjb
lgtm
3 years, 8 months ago (2017-04-10 22:55:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805393002/20001
3 years, 8 months ago (2017-04-10 23:06:31 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:00:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/73049b49ecf58eab0a0f19e2501a...

Powered by Google App Engine
This is Rietveld 408576698