Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/chromeos/net/tether_notification_presenter.h

Issue 2805393002: TetherNotificationPresenter: Connect to a network when the 'Connect' button is pressed. (Closed)
Patch Set: Remove extra constructor. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/tether_notification_presenter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/net/tether_notification_presenter.h
diff --git a/chrome/browser/chromeos/net/tether_notification_presenter.h b/chrome/browser/chromeos/net/tether_notification_presenter.h
index 09024a36e6cc8fcf034f626353b4cb0e12c78a87..1110452cbbae51dd4845ebf68779d1a638b178ce 100644
--- a/chrome/browser/chromeos/net/tether_notification_presenter.h
+++ b/chrome/browser/chromeos/net/tether_notification_presenter.h
@@ -13,6 +13,7 @@
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "chromeos/components/tether/notification_presenter.h"
+#include "chromeos/network/network_connect.h"
#include "components/cryptauth/remote_device.h"
#include "ui/message_center/message_center_observer.h"
#include "ui/message_center/notification.h"
@@ -32,7 +33,10 @@ class TetherNotificationPresenter
: public NotificationPresenter,
public message_center::MessageCenterObserver {
public:
- TetherNotificationPresenter();
+ // Caller must ensure that |message_center| amd |network_connect| outlive
+ // this instance.
+ TetherNotificationPresenter(message_center::MessageCenter* message_center,
+ NetworkConnect* network_connect);
~TetherNotificationPresenter() override;
// NotificationPresenter:
@@ -48,10 +52,6 @@ class TetherNotificationPresenter
void OnNotificationButtonClicked(const std::string& notification_id,
int button_index) override;
- protected:
- explicit TetherNotificationPresenter(
- message_center::MessageCenter* message_center);
-
private:
friend class TetherNotificationPresenterTest;
@@ -73,6 +73,7 @@ class TetherNotificationPresenter
std::unique_ptr<message_center::Notification> notification);
message_center::MessageCenter* message_center_;
+ NetworkConnect* network_connect_;
cryptauth::RemoteDevice hotspot_nearby_device_;
base::WeakPtrFactory<TetherNotificationPresenter> weak_ptr_factory_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/net/tether_notification_presenter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698