TetherNotificationPresenter: Connect to a network when the 'Connect' button is pressed.

chrome/browser/chromeos/net/tether_notification_presenter.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/net/tether_notification_presenter.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 44 matching lines @@
       // TODO(khorimoto): Add tether icon.
       gfx::Image() /* icon */, base::string16() /* display_source */,
       GURL() /* origin_url */,
       message_center::NotifierId(
           message_center::NotifierId::NotifierType::SYSTEM_COMPONENT,
           kTetherNotifierId),
       rich_notification_data, nullptr);
 }
 
 TetherNotificationPresenter::TetherNotificationPresenter()
-    : TetherNotificationPresenter(message_center::MessageCenter::Get()) {}
+    : TetherNotificationPresenter(message_center::MessageCenter::Get(),
+                                  NetworkConnect::Get()) {}

[stevenjb, 2017/04/10 19:55:51]

We shouldn't provide this extra constructor. We should pass these explicitly
wherever TetherNotificationPresenter is constructed to make it easier to check
the lifetime guarantees.

[Ryan Hansberry, 2017/04/10 22:28:55]

Done.

 
 TetherNotificationPresenter::TetherNotificationPresenter(
-    message_center::MessageCenter* message_center)
-    : message_center_(message_center), weak_ptr_factory_(this) {
+    message_center::MessageCenter* message_center,
+    NetworkConnect* network_connect)
+    : message_center_(message_center),
+      network_connect_(network_connect),
+      weak_ptr_factory_(this) {
   message_center_->AddObserver(this);
 }
 
 TetherNotificationPresenter::~TetherNotificationPresenter() {
   message_center_->RemoveObserver(this);
 }
 
 void TetherNotificationPresenter::NotifyPotentialHotspotNearby(
     const cryptauth::RemoteDevice& remote_device) {
   PA_LOG(INFO) << "Displaying \"potential hotspot nearby\" notification for "
@@ skipping 65 matching lines @@
   // TODO(khorimoto): Open the settings page.
 }
 
 void TetherNotificationPresenter::OnNotificationButtonClicked(
     const std::string& notification_id,
     int button_index) {
   PA_LOG(INFO) << "Button at index " << button_index
                << " of notification with ID " << notification_id
                << " was clicked.";
 
-  // Only the "potential hotspot nearby" notification has a button, and it only
-  // has one button (index 0).
-  DCHECK(std::string(kPotentialHotspotNotificationId) == notification_id);
-  DCHECK(0 == button_index);
-
-  // TODO(khorimoto): Start a connection.
+  if (notification_id == kPotentialHotspotNotificationId && button_index == 0) {
+    // TODO (hansberry): Only directly start a connection if this is not the
+    // first time the user has connected to a host.
+    network_connect_->ConnectToNetworkId(hotspot_nearby_device_.GetDeviceId());
+  }
 }
 
 void TetherNotificationPresenter::ShowNotification(
     std::unique_ptr<message_center::Notification> notification) {
   std::string notification_id = notification->id();
   if (message_center_->FindVisibleNotificationById(notification_id)) {
     message_center_->UpdateNotification(notification_id,
                                         std::move(notification));
   } else {
     message_center_->AddNotification(std::move(notification));
   }
 }
 
 }  // namespace tether
 
 }  // namespace chromeos