Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2807803002: Move name_value_map to remoting/base (Closed)

Created:
3 years, 8 months ago by Sergey Ulanov
Modified:
3 years, 8 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move name_value_map to remoting/base Also updated base/chromoting_event.cc to use NameValueMap Review-Url: https://codereview.chromium.org/2807803002 Cr-Commit-Position: refs/heads/master@{#463370} Committed: https://chromium.googlesource.com/chromium/src/+/4541bd67f41fcadf05cfeb4a9f10abcd04110174

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -81 lines) Patch
M remoting/base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/chromoting_event.cc View 2 chunks +19 lines, -16 lines 0 comments Download
A + remoting/base/name_value_map.h View 2 chunks +4 lines, -6 lines 0 comments Download
M remoting/host/host_exit_codes.cc View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/content_description.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/errors.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D remoting/protocol/name_value_map.h View 1 chunk +0 lines, -49 lines 0 comments Download
M remoting/protocol/negotiating_authenticator_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Sergey Ulanov
3 years, 8 months ago (2017-04-07 21:44:14 UTC) #3
joedow
lgtm
3 years, 8 months ago (2017-04-10 15:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807803002/1
3 years, 8 months ago (2017-04-10 17:27:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187508) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 17:30:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807803002/20001
3 years, 8 months ago (2017-04-10 18:41:17 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:49:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4541bd67f41fcadf05cfeb4a9f10...

Powered by Google App Engine
This is Rietveld 408576698