[Extensions Bindings] Allow schema violations through sendRequest

[Extensions Bindings] Allow schema violations through sendRequest

The context menus API is another that violates the schema is defines
when calling sendRequest() through its custom bindings. Allow these
as well, similar to how we allow them when an API updates its
arguments post validation.

The context menus API also has functions defined as properties on object
parameters, and serializes these into dictionaries. Match the the
serialization into a dictionary, but don't serialize properties of the
function.

Add an end-to-end test for the contextMenus API with native bindings.

BUG=653596
Review-Url: https://codereview.chromium.org/2805123002
Cr-Commit-Position: refs/heads/master@{#463300}
Committed: https://chromium.googlesource.com/chromium/src/+/1714411e513f2df50e5ce8ca057fe40ff3a1e449

[Devlin, 2017-04-06 21:55:40]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-04-06 21:55:40]

Another couple of ugly cases :(

Once we get all tests passing, we can audit how many APIs do this and figure out
the best way to wean ourselves off it.  So far, having some kind of public
signature, private signature combination seems the best to me, but it may depend
on how widespread this is.

For the time being, the main goal is functional parity with the current
bindings, so just making this behavior more-or-less match.

[jbroman, 2017-04-07 18:20:52]

lgtm

[lazyboy, 2017-04-07 20:31:35]

lgtm

https://codereview.chromium.org/2805123002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/context_menus_handlers.js (right):

https://codereview.chromium.org/2805123002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/context_menus_handlers.js:14:
$Function(bindingUtil.hasLastError, bindingUtil) :
$Function.bind?

[Devlin, 2017-04-08 00:14:13]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 00:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 00:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 00:18:14]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Devlin, 2017-04-08 01:45:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-08 01:46:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 02:26:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-08 02:26:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2017-04-10 15:59:07]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:44:48]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-04-10 17:05:38]

https://codereview.chromium.org/2805123002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/context_menus_handlers.js (right):

https://codereview.chromium.org/2805123002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/context_menus_handlers.js:14:
$Function(bindingUtil.hasLastError, bindingUtil) :
On 2017/04/07 20:31:34, lazyboy wrote:
> $Function.bind?

Done.

[Devlin, 2017-04-10 17:05:45]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-04-10 17:05:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2805123002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-10 17:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 17:12:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491843945364550,
"parent_rev": "5ba2e0f71b77ebe199de4269f505d4f5fe6fba09", "commit_rev":
"1714411e513f2df50e5ce8ca057fe40ff3a1e449"}

[commit-bot: I haz the power, 2017-04-10 17:13:26]

Description was changed from

==========
[Extensions Bindings] Allow schema violations through sendRequest

The context menus API is another that violates the schema is defines
when calling sendRequest() through its custom bindings. Allow these
as well, similar to how we allow them when an API updates its
arguments post validation.

The context menus API also has functions defined as properties on object
parameters, and serializes these into dictionaries. Match the the
serialization into a dictionary, but don't serialize properties of the
function.

Add an end-to-end test for the contextMenus API with native bindings.

BUG=653596
==========

to

==========
[Extensions Bindings] Allow schema violations through sendRequest

The context menus API is another that violates the schema is defines
when calling sendRequest() through its custom bindings. Allow these
as well, similar to how we allow them when an API updates its
arguments post validation.

The context menus API also has functions defined as properties on object
parameters, and serializes these into dictionaries. Match the the
serialization into a dictionary, but don't serialize properties of the
function.

Add an end-to-end test for the contextMenus API with native bindings.

BUG=653596

Review-Url: https://codereview.chromium.org/2805123002
Cr-Commit-Position: refs/heads/master@{#463300}
Committed:
https://chromium.googlesource.com/chromium/src/+/1714411e513f2df50e5ce8ca057f...
==========

[commit-bot: I haz the power, 2017-04-10 17:13:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1714411e513f2df50e5ce8ca057f...