[Extensions Bindings] Allow schema violations through sendRequest

extensions/renderer/api_binding_js_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/api_binding_js_util.h"
 
 #include "base/values.h"
 #include "extensions/renderer/api_event_handler.h"
 #include "extensions/renderer/api_request_handler.h"
 #include "extensions/renderer/api_signature.h"
@@ skipping 61 matching lines @@
     // NOTE: We don't throw any errors here if forIOThread or customCallback are
     // of invalid types. We could, if we wanted to be a bit more verbose.
     bool for_io_thread = false;
     if (options_dict.Get("forIOThread", &for_io_thread) && for_io_thread)
       thread = binding::RequestThread::IO;
     options_dict.Get("customCallback", &custom_callback);
   }
 
   std::unique_ptr<base::ListValue> converted_arguments;
   v8::Local<v8::Function> callback;
-  std::string error;
-  CHECK(signature->ParseArgumentsToJSON(context, request_args, *type_refs_,
-                                        &converted_arguments, &callback,
-                                        &error));
+
+  // Some APIs (like fileSystem and contextMenus) don't provide arguments that
+  // match the expected schema. For now, we need to ignore these and trust the
+  // JS gives us something we expect.
+  // TODO(devlin): We should ideally always be able to validate these, meaning
+  // that we either need to make the APIs give us the expected signature, or
+  // need to have a way of indicating an internal signature.
+  CHECK(signature->ConvertArgumentsIgnoringSchema(
+      context, request_args, &converted_arguments, &callback));
 
   request_handler_->StartRequest(context, name, std::move(converted_arguments),
                                  callback, custom_callback, thread);
 }
 
 void APIBindingJSUtil::RegisterEventArgumentMassager(
     gin::Arguments* arguments,
     const std::string& event_name,
     v8::Local<v8::Function> massager) {
   v8::Isolate* isolate = arguments->isolate();
@@ skipping 76 matching lines @@
   v8::Local<v8::Context> context = arguments->GetHolderCreationContext();
 
   request_handler_->last_error()->SetError(context, error);
   run_js_.Run(callback, context, 0, nullptr);
 
   bool report_if_unchecked = true;
   request_handler_->last_error()->ClearError(context, report_if_unchecked);
 }
 
 }  // namespace extensions