extensions/renderer/api_signature.cc - Issue 2805123002: [Extensions Bindings] Allow schema violations through sendRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_signature.cc

Issue 2805123002: [Extensions Bindings] Allow schema violations through sendRequest (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_signature.cc

diff --git a/extensions/renderer/api_signature.cc b/extensions/renderer/api_signature.cc

index d33423411d2ce454b245e270596318cb1e1f3ff2..683ba1ff388f634a44d08132569a43e5148562e6 100644

--- a/extensions/renderer/api_signature.cc

+++ b/extensions/renderer/api_signature.cc

@@ -305,6 +305,7 @@ bool APISignature::ConvertArgumentsIgnoringSchema(

auto json = base::MakeUnique<base::ListValue>();

std::unique_ptr<content::V8ValueConverter> converter(

content::V8ValueConverter::create());

+ converter->SetFunctionAllowed(true);

for (size_t i = 0; i < size; ++i) {

std::unique_ptr<base::Value> converted =

converter->FromV8Value(arguments[i], context);

« no previous file with comments | « extensions/renderer/api_binding_js_util.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »