Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2804903003: [Mac] Remove "Open All Bookmarks" menu items from application and wrench menus (Closed)

Created:
3 years, 8 months ago by lgrey
Modified:
3 years, 8 months ago
Reviewers:
Elly Fong-Jones, shrike
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove "Open All Bookmarks" menu items from application and wrench menus BUG=708813 Review-Url: https://codereview.chromium.org/2804903003 Cr-Commit-Position: refs/heads/master@{#466663} Committed: https://chromium.googlesource.com/chromium/src/+/e52938b242948527f56802eb6871cdc65f7a10d7

Patch Set 1 #

Patch Set 2 : Update test comments, remove reference to old selectors #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -213 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 2 2 chunks +0 lines, -54 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm View 1 2 3 chunks +4 lines, -84 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 2 2 chunks +0 lines, -43 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm View 3 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 29 (22 generated)
lgrey
PTAL :)
3 years, 8 months ago (2017-04-07 16:36:04 UTC) #10
shrike
lgtm
3 years, 8 months ago (2017-04-07 23:29:13 UTC) #11
lgrey
Thanks! +ellyjones@ for OWNERS shrike@ do you still want me to wait for the stable ...
3 years, 8 months ago (2017-04-10 14:29:34 UTC) #12
lgrey
Whoops, actually +Elly this time
3 years, 8 months ago (2017-04-10 14:43:47 UTC) #14
Elly Fong-Jones
lgtm Thanks for removing all this :D
3 years, 8 months ago (2017-04-10 14:51:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804903003/40001
3 years, 8 months ago (2017-04-24 16:55:03 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 17:03:57 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e52938b242948527f56802eb6871...

Powered by Google App Engine
This is Rietveld 408576698