Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3725)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm

Issue 2804903003: [Mac] Remove "Open All Bookmarks" menu items from application and wrench menus (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm
index 1b45a081815f15574d7a687055b578871207332a..3f58c48c72cd5e1ce8e8c1acba8c2ad2acbb41d8 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm
@@ -20,9 +20,6 @@ using bookmarks::BookmarkNode;
@public
const BookmarkNode* nodes_[2];
BOOL opened_[2];
- BOOL opened_new_foreground_tab;
- BOOL opened_new_window;
- BOOL opened_off_the_record;
}
- (id)initWithProfile:(Profile*)profile;
@end
@@ -54,17 +51,6 @@ using bookmarks::BookmarkNode;
opened_[1] = YES;
}
-- (void)openAll:(NSInteger)tag
- withDisposition:(WindowOpenDisposition)disposition {
- if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB) {
- opened_new_foreground_tab = YES;
- } else if (disposition == WindowOpenDisposition::NEW_WINDOW) {
- opened_new_window = YES;
- } else if (disposition == WindowOpenDisposition::OFF_THE_RECORD) {
- opened_off_the_record = YES;
- }
-}
-
@end // FakeBookmarkMenuController
class BookmarkMenuCocoaControllerTest : public CocoaProfileTest {
@@ -92,19 +78,4 @@ TEST_F(BookmarkMenuCocoaControllerTest, TestOpenItem) {
[c openBookmarkMenuItem:item];
ASSERT_NE(c->opened_[i], NO);
}
-
- // Test three versions of 'Open All Bookmarks' item. tag id means nothing.
- // I just reset the tag id to zero.
- [item setTag:0];
- EXPECT_EQ(c->opened_new_foreground_tab, NO);
- [c openAllBookmarks:item];
- EXPECT_NE(c->opened_new_foreground_tab, NO);
-
- EXPECT_EQ(c->opened_new_window, NO);
- [c openAllBookmarksNewWindow:item];
- EXPECT_NE(c->opened_new_window, NO);
-
- EXPECT_EQ(c->opened_off_the_record, NO);
- [c openAllBookmarksIncognitoWindow:item];
- EXPECT_NE(c->opened_off_the_record, NO);
}
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698