Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2345)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 2804903003: [Mac] Remove "Open All Bookmarks" menu items from application and wrench menus (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
index 5b201c2dbc6788c8cc9279afd764e88df913bff2..a5ef86d7e947d647a76593c011c9ae2c9f63dc84 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
@@ -103,34 +103,6 @@ const NSUInteger kMaximumMenuPixelsWide = 300;
browser->OpenURL(params);
}
-// Open sites under BookmarkNode with the specified disposition.
-- (void)openAll:(NSInteger)tag
- withDisposition:(WindowOpenDisposition)disposition {
- int identifier = tag;
-
- const BookmarkNode* node = [self nodeForIdentifier:identifier];
- DCHECK(node);
-
- Browser* browser = chrome::FindTabbedBrowser(bridge_->GetProfile(), true);
- if (!browser) {
- browser = new Browser(Browser::CreateParams(bridge_->GetProfile(), true));
- }
- DCHECK(browser);
-
- if (!node || !browser)
- return; // shouldn't be reached
-
- chrome::OpenAll(nullptr, browser, node, disposition, browser->profile());
-
- if (disposition == WindowOpenDisposition::NEW_FOREGROUND_TAB) {
- base::RecordAction(UserMetricsAction("OpenAllBookmarks"));
- } else if (disposition == WindowOpenDisposition::NEW_WINDOW) {
- base::RecordAction(UserMetricsAction("OpenAllBookmarksNewWindow"));
- } else {
- base::RecordAction(UserMetricsAction("OpenAllBookmarksIncognitoWindow"));
- }
-}
-
- (IBAction)openBookmarkMenuItem:(id)sender {
NSInteger tag = [sender tag];
int identifier = tag;
@@ -142,19 +114,4 @@ const NSUInteger kMaximumMenuPixelsWide = 300;
[self openURLForNode:node];
}
-- (IBAction)openAllBookmarks:(id)sender {
- WindowOpenDisposition disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
- [self openAll:[sender tag] withDisposition:disposition];
-}
-
-- (IBAction)openAllBookmarksNewWindow:(id)sender {
- WindowOpenDisposition disposition = WindowOpenDisposition::NEW_WINDOW;
- [self openAll:[sender tag] withDisposition:disposition];
-}
-
-- (IBAction)openAllBookmarksIncognitoWindow:(id)sender {
- WindowOpenDisposition disposition = WindowOpenDisposition::OFF_THE_RECORD;
- [self openAll:[sender tag] withDisposition:disposition];
-}
-
@end // BookmarkMenuCocoaController

Powered by Google App Engine
This is Rietveld 408576698