Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2804693002: Remove coordinates from LatencyInfo objects. (Closed)

Created:
3 years, 8 months ago by tdresser
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove coordinates from LatencyInfo objects. BUG=None Review-Url: https://codereview.chromium.org/2804693002 Cr-Commit-Position: refs/heads/master@{#465991} Committed: https://chromium.googlesource.com/chromium/src/+/27d3244a31074eeef019e8955c4ecc532fa11735

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix fuzzer test #

Total comments: 1

Patch Set 5 : Add mojo/latency_info_struct_traits.h #

Patch Set 6 : Rebase. #

Patch Set 7 : Fix mojo latencyInfo test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -244 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 1 2 3 4 5 2 chunks +0 lines, -54 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 1 2 3 4 5 7 chunks +0 lines, -66 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M ui/latency/ipc/latency_info_param_traits.cc View 4 chunks +0 lines, -25 lines 0 comments Download
M ui/latency/ipc/latency_info_param_traits_unittest.cc View 1 3 chunks +0 lines, -16 lines 0 comments Download
M ui/latency/latency_info.h View 1 2 3 4 5 3 chunks +0 lines, -13 lines 0 comments Download
M ui/latency/latency_info.cc View 1 2 3 4 5 5 chunks +5 lines, -29 lines 0 comments Download
M ui/latency/mojo/latency_info.mojom View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ui/latency/mojo/latency_info_struct_traits.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M ui/latency/mojo/latency_info_struct_traits.cc View 1 2 3 4 5 2 chunks +0 lines, -14 lines 0 comments Download
M ui/latency/mojo/struct_traits_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 44 (27 generated)
tdresser
3 years, 8 months ago (2017-04-06 20:42:37 UTC) #14
mfomitchev
https://codereview.chromium.org/2804693002/diff/60001/ui/latency/mojo/latency_info_struct_traits.cc File ui/latency/mojo/latency_info_struct_traits.cc (left): https://codereview.chromium.org/2804693002/diff/60001/ui/latency/mojo/latency_info_struct_traits.cc#oldcode246 ui/latency/mojo/latency_info_struct_traits.cc:246: StructTraits<ui::mojom::LatencyInfoDataView, You should update .h for struct traits as ...
3 years, 8 months ago (2017-04-06 21:40:53 UTC) #15
tdresser
Yikes - shouldn't that have failed to link on one of the trybots?
3 years, 8 months ago (2017-04-07 12:17:18 UTC) #16
mfomitchev
On 2017/04/07 12:17:18, tdresser wrote: > Yikes - shouldn't that have failed to link on ...
3 years, 8 months ago (2017-04-07 15:16:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804693002/80001
3 years, 8 months ago (2017-04-07 15:56:23 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/405491)
3 years, 8 months ago (2017-04-07 16:05:16 UTC) #21
tdresser
+cpu@ for ipc review. +mbarbella@ for clusterfuzz review.
3 years, 8 months ago (2017-04-07 16:09:08 UTC) #23
Martin Barbella
ipc and ipc_fuzzer changes lgtm
3 years, 8 months ago (2017-04-07 16:31:04 UTC) #24
cpu_(ooo_6.6-7.5)
I know nothing about tools/ipc_fuzzer.
3 years, 8 months ago (2017-04-15 01:53:11 UTC) #26
tdresser
+nasko@ for for ui/latency/ipc, ui/latency/mojo.
3 years, 8 months ago (2017-04-18 11:59:56 UTC) #28
nasko
Code removal, yay! LGTM
3 years, 8 months ago (2017-04-19 17:31:44 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804693002/80001
3 years, 8 months ago (2017-04-19 17:58:33 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/251371) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-19 18:02:53 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804693002/100001
3 years, 8 months ago (2017-04-19 19:58:36 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/408823)
3 years, 8 months ago (2017-04-19 20:20:58 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804693002/120001
3 years, 8 months ago (2017-04-20 12:23:38 UTC) #41
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 13:26:27 UTC) #44
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/27d3244a31074eeef019e8955c4e...

Powered by Google App Engine
This is Rietveld 408576698