Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: ui/latency/mojo/struct_traits_unittest.cc

Issue 2804693002: Remove coordinates from LatencyInfo objects. (Closed)
Patch Set: Fix mojo latencyInfo test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/latency/mojo/latency_info_struct_traits.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/latency/mojo/struct_traits_unittest.cc
diff --git a/ui/latency/mojo/struct_traits_unittest.cc b/ui/latency/mojo/struct_traits_unittest.cc
index 5a30329ccbb87b9db2b2542060385aeff43251c1..0fdd7daa4f1177d5789b187b1785d17f84c11da6 100644
--- a/ui/latency/mojo/struct_traits_unittest.cc
+++ b/ui/latency/mojo/struct_traits_unittest.cc
@@ -78,19 +78,13 @@ TEST_F(StructTraitsTest, LatencyComponentId) {
TEST_F(StructTraitsTest, LatencyInfo) {
LatencyInfo latency;
ASSERT_FALSE(latency.terminated());
- ASSERT_EQ(0u, latency.input_coordinates_size());
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234, 0);
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234, 100);
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT,
1234, 0);
- EXPECT_TRUE(latency.AddInputCoordinate(gfx::PointF(100, 200)));
- EXPECT_TRUE(latency.AddInputCoordinate(gfx::PointF(101, 201)));
- // Up to 2 InputCoordinate is allowed.
- EXPECT_FALSE(latency.AddInputCoordinate(gfx::PointF(102, 202)));
EXPECT_EQ(100, latency.trace_id());
EXPECT_TRUE(latency.terminated());
- EXPECT_EQ(2u, latency.input_coordinates_size());
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
LatencyInfo output;
@@ -98,13 +92,6 @@ TEST_F(StructTraitsTest, LatencyInfo) {
EXPECT_EQ(latency.trace_id(), output.trace_id());
EXPECT_EQ(latency.terminated(), output.terminated());
- EXPECT_EQ(latency.input_coordinates_size(), output.input_coordinates_size());
- for (size_t i = 0; i < latency.input_coordinates_size(); i++) {
- EXPECT_EQ(latency.input_coordinates()[i].x(),
- output.input_coordinates()[i].x());
- EXPECT_EQ(latency.input_coordinates()[i].y(),
- output.input_coordinates()[i].y());
- }
EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234,
nullptr));
« no previous file with comments | « ui/latency/mojo/latency_info_struct_traits.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698