Remove coordinates from LatencyInfo objects.

content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/histogram_tester.h"
 #include "components/rappor/public/rappor_utils.h"
 #include "components/rappor/test_rappor_service.h"
 #include "content/browser/renderer_host/input/render_widget_host_latency_tracker.h"
 #include "content/common/input/synthetic_web_input_event_builders.h"
 #include "content/public/browser/native_web_keyboard_event.h"
@@ skipping 180 matching lines @@
           ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
           tracker()->latency_component_id(), 0, now, 1);
       AddFakeComponentsWithTimeStamp(*tracker(), &wheel_latency, now);
       AddRenderingScheduledComponent(&wheel_latency, rendering_on_main, now);
       tracker()->OnInputEvent(wheel, &wheel_latency);
       EXPECT_TRUE(wheel_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), nullptr));
       EXPECT_TRUE(wheel_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
-      EXPECT_EQ(1U, wheel_latency.input_coordinates_size());
       tracker()->OnInputEventAck(wheel, &wheel_latency,
                                  INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
       tracker()->OnGpuSwapBuffersCompleted(wheel_latency);
 
       // Rappor metrics.
       EXPECT_TRUE(
           RapporSampleAssert("Event.Latency.ScrollUpdate.Touch."
                              "TimeToScrollUpdateSwapBegin2",
                              0));
       EXPECT_TRUE(
@@ skipping 71 matching lines @@
           ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
           tracker()->latency_component_id(), 0, now, 1);
       AddFakeComponentsWithTimeStamp(*tracker(), &wheel_latency, now);
       AddRenderingScheduledComponent(&wheel_latency, rendering_on_main, now);
       tracker()->OnInputEvent(wheel, &wheel_latency);
       EXPECT_TRUE(wheel_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), nullptr));
       EXPECT_TRUE(wheel_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
-      EXPECT_EQ(1U, wheel_latency.input_coordinates_size());
       tracker()->OnInputEventAck(wheel, &wheel_latency,
                                  INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
       tracker()->OnGpuSwapBuffersCompleted(wheel_latency);
       EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.WheelUI", 1));
       EXPECT_TRUE(HistogramSizeEq("Event.Latency.Browser.WheelAcked", 1));
 
       EXPECT_TRUE(
           HistogramSizeEq("Event.Latency.ScrollBegin.Wheel."
                           "TimeToScrollUpdateSwapBegin2",
                           0));
@@ skipping 55 matching lines @@
           ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
           tracker()->latency_component_id(), 0, now, 1);
       AddFakeComponentsWithTimeStamp(*tracker(), &scroll_latency, now);
       AddRenderingScheduledComponent(&scroll_latency, rendering_on_main, now);
       tracker()->OnInputEvent(scroll, &scroll_latency);
       EXPECT_TRUE(scroll_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), nullptr));
       EXPECT_TRUE(scroll_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
-      EXPECT_EQ(1U, scroll_latency.input_coordinates_size());
       tracker()->OnInputEventAck(scroll, &scroll_latency,
                                  INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
     }
 
     {
       SyntheticWebTouchEvent touch;
       touch.PressPoint(0, 0);
       touch.PressPoint(1, 1);
       ui::LatencyInfo touch_latency(ui::SourceEventType::TOUCH);
       base::TimeTicks now = base::TimeTicks::Now();
       touch_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
           tracker()->latency_component_id(), 0, now, 1);
       AddFakeComponentsWithTimeStamp(*tracker(), &touch_latency, now);
       AddRenderingScheduledComponent(&touch_latency, rendering_on_main, now);
       tracker()->OnInputEvent(touch, &touch_latency);
       EXPECT_TRUE(touch_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), nullptr));
       EXPECT_TRUE(touch_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
-      EXPECT_EQ(2U, touch_latency.input_coordinates_size());
       tracker()->OnInputEventAck(touch, &touch_latency,
                                  INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
       tracker()->OnGpuSwapBuffersCompleted(touch_latency);
     }
 
     // Rappor metrics.
     EXPECT_TRUE(
         RapporSampleAssert("Event.Latency.ScrollUpdate.Touch."
                            "TimeToScrollUpdateSwapBegin2",
                            0));
@@ skipping 77 matching lines @@
           ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
           tracker()->latency_component_id(), 0, now, 1);
       AddFakeComponentsWithTimeStamp(*tracker(), &scroll_latency, now);
       AddRenderingScheduledComponent(&scroll_latency, rendering_on_main, now);
       tracker()->OnInputEvent(scroll, &scroll_latency);
       EXPECT_TRUE(scroll_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), nullptr));
       EXPECT_TRUE(scroll_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
-      EXPECT_EQ(1U, scroll_latency.input_coordinates_size());
       tracker()->OnInputEventAck(scroll, &scroll_latency,
                                  INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
     }
 
     {
       SyntheticWebTouchEvent touch;
       touch.PressPoint(0, 0);
       touch.PressPoint(1, 1);
       ui::LatencyInfo touch_latency(ui::SourceEventType::TOUCH);
       base::TimeTicks now = base::TimeTicks::Now();
       touch_latency.AddLatencyNumberWithTimestamp(
           ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
           tracker()->latency_component_id(), 0, now, 1);
       AddFakeComponentsWithTimeStamp(*tracker(), &touch_latency, now);
       AddRenderingScheduledComponent(&touch_latency, rendering_on_main, now);
       tracker()->OnInputEvent(touch, &touch_latency);
       EXPECT_TRUE(touch_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
           tracker()->latency_component_id(), nullptr));
       EXPECT_TRUE(touch_latency.FindLatency(
           ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
-      EXPECT_EQ(2U, touch_latency.input_coordinates_size());
       tracker()->OnInputEventAck(touch, &touch_latency,
                                  INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
       tracker()->OnGpuSwapBuffersCompleted(touch_latency);
     }
 
     // Rappor metrics.
     EXPECT_TRUE(
         RapporSampleAssert("Event.Latency.ScrollUpdate.Touch."
                            "TimeToScrollUpdateSwapBegin2",
                            2));
@@ skipping 137 matching lines @@
       "Event.Latency.ScrollUpdate.HandledToRendererSwap_Main", 0));
   EXPECT_TRUE(HistogramSizeEq(
       "Event.Latency.ScrollUpdate.HandledToRendererSwap_Impl", 0));
   EXPECT_TRUE(HistogramSizeEq(
       "Event.Latency.ScrollUpdate.RendererSwapToBrowserNotified", 0));
   EXPECT_TRUE(HistogramSizeEq(
       "Event.Latency.ScrollUpdate.BrowserNotifiedToBeforeGpuSwap", 0));
   EXPECT_TRUE(HistogramSizeEq("Event.Latency.ScrollUpdate.GpuSwap", 0));
 }
 
-TEST_F(RenderWidgetHostLatencyTrackerTest, InputCoordinatesPopulated) {
-  {
-    auto event =
-        SyntheticWebMouseWheelEventBuilder::Build(0, 0, -5, 0, 0, true);
-    event.SetPositionInWidget(100, 200);
-    ui::LatencyInfo latency_info;
-    tracker()->OnInputEvent(event, &latency_info);
-    EXPECT_EQ(1u, latency_info.input_coordinates_size());
-    EXPECT_EQ(100, latency_info.input_coordinates()[0].x());
-    EXPECT_EQ(200, latency_info.input_coordinates()[0].y());
-  }
-
-  {
-    auto event =
-        SyntheticWebMouseEventBuilder::Build(WebInputEvent::kMouseMove);
-    event.SetPositionInWidget(300, 400);
-    ui::LatencyInfo latency_info;
-    tracker()->OnInputEvent(event, &latency_info);
-    EXPECT_EQ(1u, latency_info.input_coordinates_size());
-    EXPECT_EQ(300, latency_info.input_coordinates()[0].x());
-    EXPECT_EQ(400, latency_info.input_coordinates()[0].y());
-  }
-
-  {
-    auto event = SyntheticWebGestureEventBuilder::Build(
-        WebInputEvent::kGestureScrollBegin,
-        blink::kWebGestureDeviceTouchscreen);
-    event.x = 500;
-    event.y = 600;
-    ui::LatencyInfo latency_info;
-    tracker()->OnInputEvent(event, &latency_info);
-    EXPECT_EQ(1u, latency_info.input_coordinates_size());
-    EXPECT_EQ(500, latency_info.input_coordinates()[0].x());
-    EXPECT_EQ(600, latency_info.input_coordinates()[0].y());
-  }
-
-  {
-    SyntheticWebTouchEvent event;
-    event.PressPoint(700, 800);
-    event.PressPoint(900, 1000);
-    event.PressPoint(1100, 1200);  // LatencyInfo only holds two coordinates.
-    ui::LatencyInfo latency_info;
-    tracker()->OnInputEvent(event, &latency_info);
-    EXPECT_EQ(2u, latency_info.input_coordinates_size());
-    EXPECT_EQ(700, latency_info.input_coordinates()[0].x());
-    EXPECT_EQ(800, latency_info.input_coordinates()[0].y());
-    EXPECT_EQ(900, latency_info.input_coordinates()[1].x());
-    EXPECT_EQ(1000, latency_info.input_coordinates()[1].y());
-  }
-
-  {
-    NativeWebKeyboardEvent event(blink::WebKeyboardEvent::kKeyDown,
-                                 blink::WebInputEvent::kNoModifiers,
-                                 base::TimeTicks::Now());
-    ui::LatencyInfo latency_info;
-    tracker()->OnInputEvent(event, &latency_info);
-    EXPECT_EQ(0u, latency_info.input_coordinates_size());
-  }
-}
-
 TEST_F(RenderWidgetHostLatencyTrackerTest, ScrollLatency) {
   auto scroll_begin = SyntheticWebGestureEventBuilder::BuildScrollBegin(
       5, -5, blink::kWebGestureDeviceTouchscreen);
   ui::LatencyInfo scroll_latency;
   scroll_latency.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0,
                                   0);
   tracker()->OnInputEvent(scroll_begin, &scroll_latency);
   EXPECT_TRUE(
       scroll_latency.FindLatency(ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
                                  tracker()->latency_component_id(), nullptr));
@@ skipping 340 matching lines @@
 
     tracker()->OnInputEventAck(wheel_event, &latency, ack_state);
   }
 
   EXPECT_THAT(histogram_tester().GetAllSamples(
                   "Event.Latency.QueueingTime.MouseWheelDefaultAllowed"),
               ElementsAre(Bucket(14, 1)));
 }
 
 }  // namespace content